[GH-ISSUE #877] Links not opening in a new window/tab after #859 #505

Closed
opened 2026-02-25 21:35:12 +03:00 by kerem · 4 comments
Owner

Originally created by @PaulTGG on GitHub (Jan 31, 2024).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/877

Originally assigned to: @Yannick243 on GitHub.

🐛 Bugreport

Links not opening in a new window/tab after https://github.com/cypht-org/cypht/pull/859 was completed. The target="_blank" rel="noopener" is not showing up on external links (not to github links, at least).

Version & Environment

4f2eae309b
OS: Debian 12.4, PHP 8.2.7

Steps to reproduce

  1. Install some fresh Debian, add dependencies, install Cypht as per instructions.
  2. Try clicking an external link in an email (e.g., a github link). The link opens in the current window.
    linksinnewwindow
Originally created by @PaulTGG on GitHub (Jan 31, 2024). Original GitHub issue: https://github.com/cypht-org/cypht/issues/877 Originally assigned to: @Yannick243 on GitHub. ## 🐛 Bugreport Links not opening in a new window/tab after https://github.com/cypht-org/cypht/pull/859 was completed. The `target="_blank" rel="noopener"` is not showing up on external links (not to github links, at least). ### Version & Environment 4f2eae309b6703eed9b04486040573c1785f19c9 OS: Debian 12.4, PHP 8.2.7 ### Steps to reproduce 1. Install some fresh Debian, add dependencies, install Cypht as per instructions. 2. Try clicking an external link in an email (e.g., a github link). The link opens in the current window. ![linksinnewwindow](https://github.com/cypht-org/cypht/assets/12187131/b35d9b5e-ea29-408c-8d73-82bfe3e5b81b)
kerem closed this issue 2026-02-25 21:35:12 +03:00
Author
Owner

@Yannick243 commented on GitHub (Feb 1, 2024):

Hello @PaulTGG, thank you for reporting that.
I'm trying to reproduce the issue, and I'll get back to you shortly.

<!-- gh-comment-id:1921334762 --> @Yannick243 commented on GitHub (Feb 1, 2024): Hello @PaulTGG, thank you for reporting that. I'm trying to reproduce the issue, and I'll get back to you shortly.
Author
Owner

@Yannick243 commented on GitHub (Feb 6, 2024):

PR: https://github.com/cypht-org/cypht/pull/883

<!-- gh-comment-id:1930494082 --> @Yannick243 commented on GitHub (Feb 6, 2024): PR: [https://github.com/cypht-org/cypht/pull/883](https://github.com/cypht-org/cypht/pull/883)
Author
Owner

@Yannick243 commented on GitHub (Feb 7, 2024):

Hello @PaulTGG ,
The pull request has been merged, kindly confirm on your side.

<!-- gh-comment-id:1931514860 --> @Yannick243 commented on GitHub (Feb 7, 2024): Hello @PaulTGG , The pull request has been merged, kindly confirm on your side.
Author
Owner

@PaulTGG commented on GitHub (Feb 8, 2024):

Looks good to me. target=_blank" is showing on external links.
Screenshot_2024-02-07_21-51-11

<!-- gh-comment-id:1933406340 --> @PaulTGG commented on GitHub (Feb 8, 2024): Looks good to me. target=_blank" is showing on external links. ![Screenshot_2024-02-07_21-51-11](https://github.com/cypht-org/cypht/assets/12187131/b0548091-3173-4516-8772-f8a3b5f25a0d)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#505
No description provided.