[GH-ISSUE #795] Menu icons broken in dark mode themes #483

New issue

Closed

opened 2026-02-25 21:35:08 +03:00 by kerem · 4 comments

kerem commented

2026-02-25 21:35:08 +03:00

Owner

Originally created by @jasonmunro on GitHub (Oct 19, 2023).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/795

Originally assigned to: @kambereBr on GitHub.

🐛 Bugreport

Trash, Junk, and Drafts menu icons broken in dark themes

Version & Environment

master as of today

Steps to reproduce

Load a dark theme
observe the menu
...
Profit

Dark themes inject a path attribute into icon SVG strings to alter the color to match the theme. Icons added to lib/output.php need to be added to the list in modules/themes/modules.php to have their colors altered (this is because we don't want to blindly alter all of the icons). For 2 of these icons that are currently broken they are defined as pngs which means they will never work properly (they must be non-binary svgs). The third (trash) is an svg but still is not working they way the rest do.

Originally created by @jasonmunro on GitHub (Oct 19, 2023). Original GitHub issue: https://github.com/cypht-org/cypht/issues/795 Originally assigned to: @kambereBr on GitHub. ## 🐛 Bugreport Trash, Junk, and Drafts menu icons broken in dark themes ### Version & Environment master as of today ### Steps to reproduce 1. Load a dark theme 2. observe the menu 3. 4. ... 5. Profit Dark themes inject a path attribute into icon SVG strings to alter the color to match the theme. Icons added to lib/output.php need to be added to the list in modules/themes/modules.php to have their colors altered (this is because we don't want to blindly alter all of the icons). For 2 of these icons that are currently broken they are defined as pngs which means they will never work properly (they must be non-binary svgs). The third (trash) is an svg but still is not working they way the rest do.

kerem closed this issue

2026-02-25 21:35:08 +03:00

kerem commented

2026-02-25 21:35:09 +03:00

Author

Owner

@jasonmunro commented on GitHub (Oct 19, 2023):

@jasonmunro commented on GitHub (Oct 19, 2023): ![menu](https://github.com/cypht-org/cypht/assets/3793556/fdae682a-ff3f-430b-860f-a5b3af3daeb7)

kerem commented

2026-02-25 21:35:09 +03:00

Author

Owner

@marclaporte commented on GitHub (Oct 19, 2023):

Thank you @jasonmunro

These are 3 new item elements and we never tested with a dark theme

We will fix soon

@marclaporte commented on GitHub (Oct 19, 2023): Thank you @jasonmunro These are 3 new item elements and we never tested with a dark theme We will fix soon

kerem commented

2026-02-25 21:35:09 +03:00

Author

Owner

@marclaporte commented on GitHub (Nov 4, 2023):

@jasonmunro Is the fix OK?

@marclaporte commented on GitHub (Nov 4, 2023): @jasonmunro Is the fix OK?

kerem commented

2026-02-25 21:35:09 +03:00

Author

Owner

@jasonmunro commented on GitHub (Dec 21, 2023):