mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 04:56:03 +03:00
[GH-ISSUE #48] Problem in character encoding in Yahoo imap folders #43
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#43
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @8wmas on GitHub (Mar 17, 2016).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/48
Originally assigned to: @jasonmunro on GitHub.
I tested the software yesterday and I saw strange characters (I think that they were utf8 encodings) in the folder names of a yahoo imap account.
The folder names were in Greek
@jasonmunro commented on GitHub (Mar 17, 2016):
Thanks for the feedback. I will test this out and see what I can do.
@jasonmunro commented on GitHub (Mar 18, 2016):
Confirmed this bug and fixed it with the following commit:
github.com/jasonmunro/hm3@bb4f556344The IMAP library has the ability to handle non-ascii folder name conversion per the RFC, we just did not have it enabled! Thanks again for the feedback.
@jasonmunro commented on GitHub (Mar 18, 2016):
well, the folder with greek letters displays properly in the folder list, but trying to access it causes multiple errors:
Re-opening this until I clean the rest of these issues up.
@jasonmunro commented on GitHub (Mar 18, 2016):
OK, I think this is resolved now. We had some hacky work-arounds for odd-ball folder names, but they obviously did not correctly handle a pure non-ascii value. I just pushed the following change-set that utilizes bin2hex and hex2bin to "encode" a folder name so it can be passed around safely in the UI:
github.com/jasonmunro/hm3@060a4bd2cbThis is a much more comprehensive fix than the hacky stuff I had in place before, so thanks again for the report! Any change you could re-test with the current master branch and let me know if it's working correctly?