[GH-ISSUE #48] Problem in character encoding in Yahoo imap folders #43

Closed
opened 2026-02-25 21:33:59 +03:00 by kerem · 4 comments
Owner

Originally created by @8wmas on GitHub (Mar 17, 2016).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/48

Originally assigned to: @jasonmunro on GitHub.

I tested the software yesterday and I saw strange characters (I think that they were utf8 encodings) in the folder names of a yahoo imap account.
The folder names were in Greek

Originally created by @8wmas on GitHub (Mar 17, 2016). Original GitHub issue: https://github.com/cypht-org/cypht/issues/48 Originally assigned to: @jasonmunro on GitHub. I tested the software yesterday and I saw strange characters (I think that they were utf8 encodings) in the folder names of a yahoo imap account. The folder names were in Greek
kerem 2026-02-25 21:33:59 +03:00
  • closed this issue
  • added the
    bug
    imap
    labels
Author
Owner

@jasonmunro commented on GitHub (Mar 17, 2016):

Thanks for the feedback. I will test this out and see what I can do.

<!-- gh-comment-id:197945575 --> @jasonmunro commented on GitHub (Mar 17, 2016): Thanks for the feedback. I will test this out and see what I can do.
Author
Owner

@jasonmunro commented on GitHub (Mar 18, 2016):

Confirmed this bug and fixed it with the following commit:

github.com/jasonmunro/hm3@bb4f556344

The IMAP library has the ability to handle non-ascii folder name conversion per the RFC, we just did not have it enabled! Thanks again for the feedback.

<!-- gh-comment-id:198396065 --> @jasonmunro commented on GitHub (Mar 18, 2016): Confirmed this bug and fixed it with the following commit: https://github.com/jasonmunro/hm3/commit/bb4f556344f73c913198c5d86931cfdc8773e080 The IMAP library has the ability to handle non-ascii folder name conversion per the RFC, we just did not have it enabled! Thanks again for the feedback.
Author
Owner

@jasonmunro commented on GitHub (Mar 18, 2016):

well, the folder with greek letters displays properly in the folder list, but trying to access it causes multiple errors:

  • javascript errors thrown about a invalid selector
  • bad formatting of the folder name in the message list heading
  • probably more!

Re-opening this until I clean the rest of these issues up.

<!-- gh-comment-id:198409283 --> @jasonmunro commented on GitHub (Mar 18, 2016): well, the folder with greek letters displays properly in the folder list, but trying to access it causes multiple errors: - javascript errors thrown about a invalid selector - bad formatting of the folder name in the message list heading - probably more! Re-opening this until I clean the rest of these issues up.
Author
Owner

@jasonmunro commented on GitHub (Mar 18, 2016):

OK, I think this is resolved now. We had some hacky work-arounds for odd-ball folder names, but they obviously did not correctly handle a pure non-ascii value. I just pushed the following change-set that utilizes bin2hex and hex2bin to "encode" a folder name so it can be passed around safely in the UI:

github.com/jasonmunro/hm3@060a4bd2cb

This is a much more comprehensive fix than the hacky stuff I had in place before, so thanks again for the report! Any change you could re-test with the current master branch and let me know if it's working correctly?

<!-- gh-comment-id:198464035 --> @jasonmunro commented on GitHub (Mar 18, 2016): OK, I think this is resolved now. We had some hacky work-arounds for odd-ball folder names, but they obviously did not correctly handle a pure non-ascii value. I just pushed the following change-set that utilizes bin2hex and hex2bin to "encode" a folder name so it can be passed around safely in the UI: https://github.com/jasonmunro/hm3/commit/060a4bd2cb6f0453f22544397f9403371f6ea9e5 This is a much more comprehensive fix than the hacky stuff I had in place before, so thanks again for the report! Any change you could re-test with the current master branch and let me know if it's working correctly?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#43
No description provided.