starred/cypht

Fork 0

mirror of https://github.com/cypht-org/cypht.git synced 2026-04-25 13:05:53 +03:00

[GH-ISSUE #597] Decide if composer.lock should be tracked in Git (or stay with composer.lock in .gitignore) #418

New issue

Closed

opened 2026-02-25 21:34:58 +03:00 by kerem · 6 comments

kerem commented

2026-02-25 21:34:58 +03:00

Owner

Originally created by @marclaporte on GitHub (Aug 14, 2022).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/597

https://stackoverflow.com/questions/12896780/should-composer-lock-be-committed-to-version-control

https://search.brave.com/search?q=composer.lock

composer.lock is now in https://github.com/jasonmunro/cypht/blob/master/.gitignore

Originally created by @marclaporte on GitHub (Aug 14, 2022). Original GitHub issue: https://github.com/cypht-org/cypht/issues/597 https://stackoverflow.com/questions/12896780/should-composer-lock-be-committed-to-version-control https://search.brave.com/search?q=composer.lock composer.lock is now in https://github.com/jasonmunro/cypht/blob/master/.gitignore Related: https://github.com/jasonmunro/cypht/issues/311

kerem closed this issue

2026-02-25 21:34:58 +03:00

kerem commented

2026-02-25 21:34:59 +03:00

Author

Owner

@marclaporte commented on GitHub (Aug 22, 2022):

Related chat thread on Gitter: https://gitter.im/cypht-org/community?at=62fa629511a6a83d040e77fb

@marclaporte commented on GitHub (Aug 22, 2022): Related chat thread on Gitter: https://gitter.im/cypht-org/community?at=62fa629511a6a83d040e77fb

kerem commented

2026-02-25 21:34:59 +03:00

Author

Owner

@Tea23 commented on GitHub (Sep 26, 2022):

Removing composer.lock has caused an issue with install. As composer.json contains the pre install and pre update commands composer check-platform-reqs, composer install expects a lockfile to be present.

I'm a neophyte with composer and stuff, so I worked around this by replacing the commands in pre-install and pre-update with echo hi and then composer install correctly generated the lockfile.

@Tea23 commented on GitHub (Sep 26, 2022): Removing composer.lock has caused an issue with install. As composer.json contains the pre install and pre update commands `composer check-platform-reqs`, `composer install` expects a lockfile to be present. I'm a neophyte with composer and stuff, so I worked around this by replacing the commands in pre-install and pre-update with `echo hi` and then `composer install` correctly generated the lockfile.

kerem commented

2026-02-25 21:34:59 +03:00

Author

Owner

@kk6mrp commented on GitHub (Oct 1, 2022):

Removing composer.lock has caused an issue with install. As composer.json contains the pre install and pre update commands composer check-platform-reqs, composer install expects a lockfile to be present.

I'm having this same issue when trying to update.

@kk6mrp commented on GitHub (Oct 1, 2022): > Removing composer.lock has caused an issue with install. As composer.json contains the pre install and pre update commands `composer check-platform-reqs`, `composer install` expects a lockfile to be present. I'm having this same issue when trying to update.

kerem commented

2026-02-25 21:34:59 +03:00

Author

Owner

@marclaporte commented on GitHub (Nov 1, 2022):

@marclaporte commented on GitHub (Nov 1, 2022): Related: https://github.com/jasonmunro/cypht/pull/632/files

kerem commented

2026-02-25 21:34:59 +03:00

Author

Owner

@marclaporte commented on GitHub (Jul 7, 2023):

For the record, composer.lock was removed here: github.com/cypht-org/cypht@131daacbeb

And it's highly likely we will resume maintaining composer.lock in Git

@marclaporte commented on GitHub (Jul 7, 2023): For the record, composer.lock was removed here: https://github.com/cypht-org/cypht/commit/131daacbeb765671ad6d0c90fb4085cb2c9c2eae And it's highly likely we will resume maintaining composer.lock in Git

kerem commented

2026-02-25 21:34:59 +03:00

Author

Owner

@marclaporte commented on GitHub (Jul 11, 2023):

composer.lock is now back in the code base:
github.com/cypht-org/cypht@58f007a324

@marclaporte commented on GitHub (Jul 11, 2023): composer.lock is now back in the code base: https://github.com/cypht-org/cypht/commit/58f007a3240d4a06cc806982fc3bc37f7b6d9112

kerem referenced this issue

2026-02-25 21:36:18 +03:00

[PR #418] [MERGED] add default sort order for imap folders - arrival or sent date #810

kerem referenced this issue

2026-02-25 21:36:18 +03:00

[PR #434] [MERGED] Expose default sort order even on combined message views #813

kerem referenced this issue

2026-02-25 21:36:19 +03:00

[PR #443] [MERGED] fix default sort order label (Arrival vs Sent Date) throughout the codebase #815