mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 04:56:03 +03:00
[GH-ISSUE #486] Login button is not button-like (mouse does not indicate it can be clicked, and clicking it does nothing visible) #384
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#384
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gitcnd on GitHub (Jun 1, 2021).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/486
Originally assigned to: @jasonmunro on GitHub.
🗣 Suggestion
@jasonmunro commented on GitHub (Jun 8, 2021):
The login page has no JavaScript (unless you enable reCaptcha) and the button is a standard submit input element. you are right it does not look clickable so I will fix that.
Not sure what you mean by it's not doing anything (?) I think it might just be failing very quickly and not showing the proper notice on failure (as you mention in the other issue) so it appears to be doing nothing. It is just a normal HTML submit element so as long as the 2 required fields are filled out it will submit the form over standard HTTP(S). If the 2 required fields (username and password) are not filled out it is up to the browser to handle the interaction WRT required fields.
@gitcnd commented on GitHub (Jun 8, 2021):
Weird - I'll do a screencast if it happens again - my box is on the other side of the world, so how I could have missed any kind of browser feedback to a form submit I don't know! (I repeated it several times)...
The CSS definitely needs a tweak - normal default buttons change on mouseover, look like buttons, and also change when clicked - you somehow made your button look like an input box, with no change or action on mouseover or click - but that's just nitpicky of course - the main problem is the "no error showing" when errors were encountered.
@jasonmunro commented on GitHub (Jun 8, 2021):
I must have a blanket css rule that is disrupting the default pointer for buttons so I just added it directly to the login button and now it behaves the way one expects. I agree the main problem is the missing error message so I'm going to fix that and follow up on that issue and close this one. Thanks for the feedback!