starred/cypht

Fork 0

mirror of https://github.com/cypht-org/cypht.git synced 2026-04-25 13:05:53 +03:00

[GH-ISSUE #439] Add Archive action to lists (All Mail, Basic Search, Advanced Search, etc.) #364

New issue

Closed

opened 2026-02-25 21:34:51 +03:00 by kerem · 15 comments

kerem commented

2026-02-25 21:34:51 +03:00

Owner

Originally created by @marclaporte on GitHub (Oct 6, 2020).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/439

Originally assigned to: @jasonmunro on GitHub.

We have https://github.com/jasonmunro/cypht/issues/228 Great!

Please keep in mind that archiving acts differently in each account (it is configurable) so if we are in "All Mail" interface, each mail needs to be archived as if we launched the action directly on the email.

Originally created by @marclaporte on GitHub (Oct 6, 2020). Original GitHub issue: https://github.com/cypht-org/cypht/issues/439 Originally assigned to: @jasonmunro on GitHub. We have https://github.com/jasonmunro/cypht/issues/228 Great! ![2020-10-06_152437](https://user-images.githubusercontent.com/1004261/95250739-829bfc80-07e8-11eb-889f-001c97c5ee2d.png) Please keep in mind that archiving acts differently in each account (it is configurable) so if we are in "All Mail" interface, each mail needs to be archived as if we launched the action directly on the email.

kerem closed this issue

2026-02-25 21:34:51 +03:00

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@jasonmunro commented on GitHub (Oct 22, 2020):

PR for this has been merged so pretty sure we can close this out @marclaporte

@jasonmunro commented on GitHub (Oct 22, 2020): PR for this has been merged so pretty sure we can close this out @marclaporte

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@marclaporte commented on GitHub (Oct 22, 2020):

Testing with latest Cypht from Packagist bundled in Tiki:
I see the buttons in advanced search and all mail, but clicking on it does nothing. Perhaps I have some sticky cache?

@marclaporte commented on GitHub (Oct 22, 2020): Testing with latest Cypht from Packagist bundled in Tiki: I see the buttons in advanced search and all mail, but clicking on it does nothing. Perhaps I have some sticky cache?

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@jasonmunro commented on GitHub (Oct 23, 2020):

I actually did not test the archive process. Do you have archive folders setup for your accounts?

@jasonmunro commented on GitHub (Oct 23, 2020): I actually did not test the archive process. Do you have archive folders setup for your accounts?

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@marclaporte commented on GitHub (Oct 23, 2020):

When archiving from an email view, Cypht uses a default pattern (which I am OK with) and it creates folders as needed.

So I usually do not set anything. I expect archive from search or list to work the same way.

@marclaporte commented on GitHub (Oct 23, 2020): When archiving from an email view, Cypht uses a default pattern (which I am OK with) and it creates folders as needed. So I usually do not set anything. I expect archive from search or list to work the same way.

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@jasonmunro commented on GitHub (Oct 23, 2020):

I respectfully disagree about that. An archive folder is IMO like a special folder (sent/trash/drafts) and auto-creating those is I think a presumptuous action for a webmail client. Not to say we could not auto-create one via the nux module or a different avenue, but at the time of an archive action is IMO too late. Auto-creating also makes some assumptions I don't think we want to make (i18n for example).

@jasonmunro commented on GitHub (Oct 23, 2020): I respectfully disagree about that. An archive folder is IMO like a special folder (sent/trash/drafts) and auto-creating those is I think a presumptuous action for a webmail client. Not to say we could not auto-create one via the nux module or a different avenue, but at the time of an archive action is IMO too late. Auto-creating also makes some assumptions I don't think we want to make (i18n for example).

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@marclaporte commented on GitHub (Oct 23, 2020):

I see what you mean. The current behavior is not what I was expecting, but that is what @yvesdaxmaz coded and I felt it was good enough (and we could always improve later). The archive discussion was here: https://github.com/jasonmunro/cypht/issues/228

I use "Archive" all the time. But other users may prefer to only have the archive button if the archive feature is set up. But then, we'll get feedback from @dumblob about how buttons should not change :-)

So @jasonmunro, how shall we proceed now?

@marclaporte commented on GitHub (Oct 23, 2020): I see what you mean. The current behavior is not what I was expecting, but that is what @yvesdaxmaz coded and I felt it was good enough (and we could always improve later). The archive discussion was here: https://github.com/jasonmunro/cypht/issues/228 I use "Archive" all the time. But other users may prefer to only have the archive button if the archive feature is set up. But then, we'll get feedback from @dumblob about how buttons should not change :-) So @jasonmunro, how shall we proceed now?

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@marclaporte commented on GitHub (Oct 27, 2020):

Thank you @jasonmunro for github.com/jasonmunro/cypht@268ec8a5d8

I will test.

@marclaporte commented on GitHub (Oct 27, 2020): Thank you @jasonmunro for https://github.com/jasonmunro/cypht/commit/268ec8a5d8c1f8a2d9296e2a5cb5907b476434d9 I will test.

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@marclaporte commented on GitHub (Oct 27, 2020):

When I try to archive a few messages from a list (or advanced search), I get "An error occurred trying to archive some messages!" (How can I find out what is the error? logs? debug mode? Could the message be more explicit?)

But if I go on individual messages, the archive button works fine, even without setting an archive folder.

@marclaporte commented on GitHub (Oct 27, 2020): When I try to archive a few messages from a list (or advanced search), I get "An error occurred trying to archive some messages!" (How can I find out what is the error? logs? debug mode? Could the message be more explicit?) But if I go on individual messages, the archive button works fine, even without setting an archive folder.

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@jasonmunro commented on GitHub (Oct 27, 2020):

looks like we still have issues, and the auto-create if it does not exist is still present. I'm going to remove that today and clean up the rest. I will tie it to this issue when I push the fixes.

@jasonmunro commented on GitHub (Oct 27, 2020): looks like we still have issues, and the auto-create if it does not exist is still present. I'm going to remove that today and clean up the rest. I will tie it to this issue when I push the fixes.

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@marclaporte commented on GitHub (Oct 28, 2020):

With latest code: Nice error message if Archive folder is not set. And it then works on one message.

But does not work in list mode where I get "An error occurred trying to archive some messages!"

@marclaporte commented on GitHub (Oct 28, 2020): With latest code: Nice error message if Archive folder is not set. And it then works on one message. But does not work in list mode where I get "An error occurred trying to archive some messages!"

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@jasonmunro commented on GitHub (Oct 28, 2020):

works fine here so I'm not sure what is happening. Likely need to log the IMAP debug info

@jasonmunro commented on GitHub (Oct 28, 2020): works fine here so I'm not sure what is happening. Likely need to log the IMAP debug info

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@marclaporte commented on GitHub (Oct 28, 2020):

Ok, I think that it's because Cypht in Tiki is not reliably saving the archive folder setting. So I will close as done, and re-open if relevant.

Thanks!

@marclaporte commented on GitHub (Oct 28, 2020): Ok, I think that it's because Cypht in Tiki is not reliably saving the archive folder setting. So I will close as done, and re-open if relevant. Thanks!

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@Steven-- commented on GitHub (May 8, 2022):

I'm having the same problem as @marclaporte on a fresh Cypht install on Debian 11.
Using the debug mode does not seem to produce any useful messages on the error log. What kind of info can I provide to help troubleshoot the issue?

Also, this is probably a dumb question, but how do I check the version of the installed Cypht? I don't see it reported anywhere.

@Steven-- commented on GitHub (May 8, 2022): I'm having the same problem as @marclaporte on a fresh Cypht install on Debian 11. Using the debug mode does not seem to produce any useful messages on the error log. What kind of info can I provide to help troubleshoot the issue? Also, this is probably a dumb question, but how do I check the version of the installed Cypht? I don't see it reported anywhere.

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@marclaporte commented on GitHub (May 9, 2022):

@Steven-- I'll re-open this.

Can you join us on https://gitter.im/cypht-org/community so we can troubleshoot?

Thanks!

@marclaporte commented on GitHub (May 9, 2022): @Steven-- I'll re-open this. Can you join us on https://gitter.im/cypht-org/community so we can troubleshoot? Thanks!

kerem commented

2026-02-25 21:34:51 +03:00

Author

Owner

@Steven-- commented on GitHub (May 9, 2022):

@marclaporte Sure! I'm a bit busy at the moment but I'll join in a few days. Thank you.

@Steven-- commented on GitHub (May 9, 2022): @marclaporte Sure! I'm a bit busy at the moment but I'll join in a few days. Thank you.