mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 21:15:56 +03:00
[GH-ISSUE #429] UTF8 corruption when replying as text to HTML message part #357
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#357
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jasonmunro on GitHub (Sep 16, 2020).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/429
Originally assigned to: @jasonmunro on GitHub.
This only happens when replying to an HTML prt with outbound mail set to TEXT. All other combinations work fine.
@jasonmunro commented on GitHub (Sep 16, 2020):
Update - actually replying to the HTML part when using outbound of MARKDOWN also fails.
@marclaporte commented on GitHub (Sep 16, 2020):
With 1.9 million downloads, maybe this can help: https://packagist.org/packages/soundasleep/html2text
@jasonmunro commented on GitHub (Sep 17, 2020):
@jasonmunro commented on GitHub (Sep 17, 2020):
@marclaporte should be fixed in master. While we can't use the package you posted, it is a good reference for potential issues around HTML -> TEXT conversion. I happened to find this fix elsewhere but still very useful so thanks for the post. I will leave this open for you to confirm on your end the problem is resolved.
Thanks!
@marclaporte commented on GitHub (Sep 17, 2020):
About "php: >=7.0": We can use an older version https://packagist.org/packages/soundasleep/html2text#0.5.0 until our requirements increase.
@marclaporte commented on GitHub (Sep 17, 2020):
Ah wait, older versions are licensed EPL-1.0, and I don't know off-hand if it's compatible. In any case, we'll sooner or later increase minimum requirements, and the lib will become an option at that point: https://github.com/jasonmunro/cypht/issues/431
@jasonmunro commented on GitHub (Sep 17, 2020):
Well what we have works fine for now and honestly is not very different than what this third party code does.
@marclaporte commented on GitHub (Sep 17, 2020):
@jasonmunro understood.
I think we can close this issue. It works for me with the newest code.
Thanks!