starred/cypht

Fork 0

mirror of https://github.com/cypht-org/cypht.git synced 2026-04-25 04:56:03 +03:00

[GH-ISSUE #39] Interface language clean up #35

New issue

Closed

opened 2026-02-25 21:33:58 +03:00 by kerem · 17 comments

kerem commented

2026-02-25 21:33:58 +03:00

Owner

Originally created by @jasonmunro on GitHub (Mar 7, 2016).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/39

Originally assigned to: @jasonmunro on GitHub.

Many of the interface languages were generated with the google translate api - from what I have been told they are hilariously bad. Remove these and leave the 2 (?) actual translations.

Add missing strings per the debug output for each page to the remaining translation files

Originally created by @jasonmunro on GitHub (Mar 7, 2016). Original GitHub issue: https://github.com/cypht-org/cypht/issues/39 Originally assigned to: @jasonmunro on GitHub. Many of the interface languages were generated with the google translate api - from what I have been told they are hilariously bad. Remove these and leave the 2 (?) actual translations. Add missing strings per the debug output for each page to the remaining translation files

kerem

2026-02-25 21:33:58 +03:00

closed this issue
added the
core

I18N
labels

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@jasonmunro commented on GitHub (Mar 9, 2016):

fixed in master

@jasonmunro commented on GitHub (Mar 9, 2016): fixed in master

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@mat-m commented on GitHub (Mar 13, 2016):

Hello
I did a fresh translation for french, added it in the language folder, but even a php ./config_gen.php did not update the language list in the settings. What do I miss ?

@mat-m commented on GitHub (Mar 13, 2016): Hello I did a fresh translation for french, added it in the language folder, but even a php ./config_gen.php did not update the language list in the settings. What do I miss ?

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@jasonmunro commented on GitHub (Mar 13, 2016):

Thanks for doing this! There is a function in the core modules that defines the list of available langs:
https://github.com/jasonmunro/hm3/blob/master/modules/core/functions.php#L50
So once you add to that it should be available in the settings.

@jasonmunro commented on GitHub (Mar 13, 2016): Thanks for doing this! There is a function in the core modules that defines the list of available langs: https://github.com/jasonmunro/hm3/blob/master/modules/core/functions.php#L50 So once you add to that it should be available in the settings.

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@mat-m commented on GitHub (Mar 13, 2016):

Found and fixed.
Some issues about translations:

Date (Mont, Year) in calendar is not translated
Some Messages list titles are not translated (although their entry in the left menu is): Flagged, Unread, Everything, All Email
In the homepage:

POP3 services are not enabled for this site. Sorry about that!

is not translated, nor the "Update" Link for the timezone

@mat-m commented on GitHub (Mar 13, 2016): Found and fixed. Some issues about translations: - Date (Mont, Year) in calendar is not translated - Some Messages list titles are not translated (although their entry in the left menu is): Flagged, Unread, Everything, All Email - In the homepage: > POP3 services are not enabled for this site. Sorry about that! is not translated, nor the "Update" Link for the timezone

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@jasonmunro commented on GitHub (Mar 13, 2016):

Thanks for tracking those down. All of the missing translations you mentioned should now be fixed.

@jasonmunro commented on GitHub (Mar 13, 2016): Thanks for tracking those down. All of the missing translations you mentioned should now be fixed.

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@dumblob commented on GitHub (Mar 13, 2016):

I just spotted, that the comment on https://github.com/jasonmunro/hm3/blob/master/modules/core/functions.php#L46 doesn't reflect this decision to throw away the Google-translated strings ;)

@dumblob commented on GitHub (Mar 13, 2016): I just spotted, that the comment on https://github.com/jasonmunro/hm3/blob/master/modules/core/functions.php#L46 doesn't reflect this decision to throw away the Google-translated strings ;)

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@jasonmunro commented on GitHub (Mar 14, 2016):

Good catch! Now fixed.

@jasonmunro commented on GitHub (Mar 14, 2016): Good catch! Now fixed.

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@jasonmunro commented on GitHub (Mar 15, 2016):

mat-m, I would love to merge your corrected French translation when you are ready. Just send me a pull request and I will merge it. Thanks!

@jasonmunro commented on GitHub (Mar 15, 2016): mat-m, I would love to merge your corrected French translation when you are ready. Just send me a pull request and I will merge it. Thanks!

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@mat-m commented on GitHub (May 14, 2016):

The line 'Add An E-mail Account' => false, has disappeared from en.php and is not translated anymore.
Keys copy and move should be lowercase in language files
We should have an entry for Download (attachments)

@mat-m commented on GitHub (May 14, 2016): The line `'Add An E-mail Account' => false,` has disappeared from en.php and is not translated anymore. Keys `copy` and `move` should be lowercase in language files We should have an entry for `Download` (attachments)

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@jasonmunro commented on GitHub (May 16, 2016):

The problem with the add an email account string, and the copy/move strings, is they are used in multiple places with different capitalization. I'm going to get this cleaned up today. Strings in the lang files that need a leading capital in some cases and lowercase in others will be defined with the capital in the translation file, and I will use css to convert them to lowercase where need be. I will also add the missing download link.

@jasonmunro commented on GitHub (May 16, 2016): The problem with the add an email account string, and the copy/move strings, is they are used in multiple places with different capitalization. I'm going to get this cleaned up today. Strings in the lang files that need a leading capital in some cases and lowercase in others will be defined with the capital in the translation file, and I will use css to convert them to lowercase where need be. I will also add the missing download link.

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@jasonmunro commented on GitHub (May 16, 2016):

Just pushed fixes for everything and merged the latest pull requests WRT to i18n. Thanks everyone for the feedback. If you notice anything else please let me know!

@jasonmunro commented on GitHub (May 16, 2016): Just pushed fixes for everything and merged the latest pull requests WRT to i18n. Thanks everyone for the feedback. If you notice anything else please let me know!

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@mat-m commented on GitHub (May 18, 2016):

The gear in front of the profiles name has a tip "Edit" which is not translated
Same applies for Edit, Delete and Send To in local contacts.

Since the translations exist, it is more a problem of using it in the code.

@mat-m commented on GitHub (May 18, 2016): The gear in front of the profiles name has a tip "Edit" which is not translated Same applies for Edit, Delete and Send To in local contacts. Since the translations exist, it is more a problem of using it in the code.

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@jasonmunro commented on GitHub (May 18, 2016):

Good catch! Fixed in github.com/jasonmunro/hm3@c0db0ae2c8
Thanks!

@jasonmunro commented on GitHub (May 18, 2016): Good catch! Fixed in https://github.com/jasonmunro/hm3/commit/c0db0ae2c8fb881acb9b0e545e22cfb451d77855 Thanks!

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@jasonmunro commented on GitHub (Jun 21, 2016):

Added some new strings today. I think we are getting close to being i18n complete.

@jasonmunro commented on GitHub (Jun 21, 2016): Added some new strings today. I think we are getting close to being i18n complete.

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@jasonmunro commented on GitHub (Aug 30, 2016):

Another round of strings added to the language files for the latest feature updates

@jasonmunro commented on GitHub (Aug 30, 2016): Another round of strings added to the language files for the latest feature updates

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@jasonmunro commented on GitHub (Apr 14, 2017):

Added more strings to the language files. I'm planning a release soon, so if anybody has time to update a language it would be much appreciated!

@jasonmunro commented on GitHub (Apr 14, 2017): Added more strings to the language files. I'm planning a release soon, so if anybody has time to update a language it would be much appreciated!

kerem commented

2026-02-25 21:33:58 +03:00

Author

Owner

@jasonmunro commented on GitHub (Sep 24, 2018):

so much for that soon to be created "release" from April 2017! I'm actually thinking about this again, so I will create a more specific issue around translations if need be. I'm trying to remove generic issues that don't get attention and replace them with more specific ones that are easier to deal with, so i"m closing this.

@jasonmunro commented on GitHub (Sep 24, 2018): so much for that soon to be created "release" from April 2017! I'm actually thinking about this again, so I will create a more specific issue around translations if need be. I'm trying to remove generic issues that don't get attention and replace them with more specific ones that are easier to deal with, so i"m closing this.