[GH-ISSUE #323] 🐛 [Compose] Detaching & Reattaching of files does not work #277

Closed
opened 2026-02-25 21:34:38 +03:00 by kerem · 7 comments
Owner

Originally created by @ulfgebhardt on GitHub (Mar 6, 2019).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/323

Originally assigned to: @jasonmunro on GitHub.

🐛 Bugreport

[Compose] Detaching & Reattaching of files does not work

Consider following Situation:

  • You want to send a File and start writing the EMail and attach the File
  • Now you notice there is a mistake in the File while writing
  • You correct the Mistake, detach the file, and try to reattach it.
  • The File does not appear, you have the start another compose

This is probl. the case since the file name has not changed.
(I did not try with a changed filename)

Version & Environment

Rev: 70a3d129f0493d7885176040b39a69d51c422921

OS: [Debian]

Steps to reproduce

  1. Attach File
  2. Detach File
  3. Reattach same File (or changed File with same name/path)
  4. ...
  5. Profit
Originally created by @ulfgebhardt on GitHub (Mar 6, 2019). Original GitHub issue: https://github.com/cypht-org/cypht/issues/323 Originally assigned to: @jasonmunro on GitHub. ## 🐛 Bugreport <!-- Describe your issue in detail. Include screenshots if needed. Give us as much information as possible. --> ### [Compose] Detaching & Reattaching of files does not work Consider following Situation: - You want to send a File and start writing the EMail and attach the File - Now you notice there is a mistake in the File while writing - You correct the Mistake, detach the file, and try to reattach it. - The File does not appear, you have the start another compose This is probl. the case since the file name has not changed. (I did not try with a changed filename) ### Version & Environment <!-- Paste Git-Commit ID or Tag-Name here --> Rev: [70a3d129f0493d7885176040b39a69d51c422921](https://github.com/jasonmunro/cypht/commit/70a3d129f0493d7885176040b39a69d51c422921) <!-- Specify your OS and OS Version here if the issue is (most likely) platform dependent. --> OS: [Debian] ### Steps to reproduce 1. Attach File 2. Detach File 3. Reattach same File (or changed File with same name/path) 4. ... 5. Profit
kerem 2026-02-25 21:34:38 +03:00
Author
Owner

@jasonmunro commented on GitHub (Mar 20, 2019):

This appears to be a Javascript bug as the second attempt to attach the file never triggers a server side request. I think the problem is using a change event as part of the flow. Re-uploading the same file is not a change in state so it never triggers the actual upload. I will let you know when I have a fix.

<!-- gh-comment-id:475051561 --> @jasonmunro commented on GitHub (Mar 20, 2019): This appears to be a Javascript bug as the second attempt to attach the file never triggers a server side request. I think the problem is using a change event as part of the flow. Re-uploading the same file is not a change in state so it never triggers the actual upload. I will let you know when I have a fix.
Author
Owner

@jasonmunro commented on GitHub (Mar 20, 2019):

Should be fixed in the master branch

<!-- gh-comment-id:475056847 --> @jasonmunro commented on GitHub (Mar 20, 2019): Should be fixed in the master branch
Author
Owner

@jasonmunro commented on GitHub (Jul 3, 2019):

@ulfgebhardt I believe this is fixed so I'm closing this issue. If you are still seeing issues please re-open. Thanks!

<!-- gh-comment-id:507900579 --> @jasonmunro commented on GitHub (Jul 3, 2019): @ulfgebhardt I believe this is fixed so I'm closing this issue. If you are still seeing issues please re-open. Thanks!
Author
Owner

@ulfgebhardt commented on GitHub (Jul 3, 2019):

Hey @jasonmunro i am sorry that i did not respond in a timely manner - haven't updated cypht in quite some time. <3

<!-- gh-comment-id:508131317 --> @ulfgebhardt commented on GitHub (Jul 3, 2019): Hey @jasonmunro i am sorry that i did not respond in a timely manner - haven't updated cypht in quite some time. <3
Author
Owner

@marclaporte commented on GitHub (Mar 17, 2021):

Related: https://github.com/jasonmunro/cypht/issues/421

<!-- gh-comment-id:801155917 --> @marclaporte commented on GitHub (Mar 17, 2021): Related: https://github.com/jasonmunro/cypht/issues/421
Author
Owner

@marclaporte commented on GitHub (Mar 17, 2021):

@ulfgebhardt Please retest with latest code.

Thanks!

<!-- gh-comment-id:801156842 --> @marclaporte commented on GitHub (Mar 17, 2021): @ulfgebhardt Please retest with latest code. Thanks!
Author
Owner

@ulfgebhardt commented on GitHub (Mar 17, 2021):

@marclaporte I will in time, I still work with quite the old version of cypht. Will update some day I guess <3

<!-- gh-comment-id:801250733 --> @ulfgebhardt commented on GitHub (Mar 17, 2021): @marclaporte I will in time, I still work with quite the old version of cypht. Will update some day I guess <3
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#277
No description provided.