[GH-ISSUE #264] 🕷Text-Mail Links take closing bracket ] into link #226

Closed
opened 2026-02-25 21:34:29 +03:00 by kerem · 2 comments
Owner

Originally created by @ulfgebhardt on GitHub (Feb 18, 2018).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/264

Originally assigned to: @jasonmunro on GitHub.

image

Text EMails with [Brackets] enclosing links cause the href of the generated a-tag to include the closing bracket.

Reference: https://stackoverflow.com/a/13227416/1326872

Rev: 4e16293ba8

Grüße Ulf

<3

Originally created by @ulfgebhardt on GitHub (Feb 18, 2018). Original GitHub issue: https://github.com/cypht-org/cypht/issues/264 Originally assigned to: @jasonmunro on GitHub. ![image](https://user-images.githubusercontent.com/1238238/36351420-c47dc514-14a9-11e8-83b6-49a2a7ca8d7f.png) Text EMails with [Brackets] enclosing links cause the href of the generated a-tag to include the closing bracket. Reference: https://stackoverflow.com/a/13227416/1326872 Rev: 4e16293ba8f05c6ed6ac94d32ebd48980a7a4b40 Grüße Ulf <3
kerem 2026-02-25 21:34:29 +03:00
  • closed this issue
  • added the
    bug
    core
    labels
Author
Owner

@jasonmunro commented on GitHub (Feb 19, 2018):

square brackets in urls should be encoded, not sure why we were letting these through. Likely it's the "clients should be strict in what they produce, and forgiving in what the except" rule :). I have removed them from the allowed characters in the regex match, so this should be resolved.

<!-- gh-comment-id:366771572 --> @jasonmunro commented on GitHub (Feb 19, 2018): square brackets in urls should be encoded, not sure why we were letting these through. Likely it's the "clients should be strict in what they produce, and forgiving in what the except" rule :). I have removed them from the allowed characters in the regex match, so this should be resolved.
Author
Owner

@jasonmunro commented on GitHub (Mar 14, 2018):

This should be fixed, so I'm closing. Please re-open if you find otherwise!

<!-- gh-comment-id:373212994 --> @jasonmunro commented on GitHub (Mar 14, 2018): This should be fixed, so I'm closing. Please re-open if you find otherwise!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#226
No description provided.