[GH-ISSUE #260] Split/Cleanup Session handler #222

New issue

Closed

opened 2026-02-25 21:34:29 +03:00 by kerem · 4 comments

kerem commented

2026-02-25 21:34:29 +03:00

Owner

Originally created by @Yamakasi on GitHub (Feb 8, 2018).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/260

Hi,

Because I'm reviewing the sessionhandler for extending it for my own needs I also see that a lot of extending classes are used for several of backends that don't need eachother but only their functions.

As this is not ideal, is some split/cleanup to sesssion_base.php a willing cleanup ? I might be able to do this the next days.

Let me know.

Originally created by @Yamakasi on GitHub (Feb 8, 2018). Original GitHub issue: https://github.com/cypht-org/cypht/issues/260 Hi, Because I'm reviewing the sessionhandler for extending it for my own needs I also see that a lot of extending classes are used for several of backends that don't need eachother but only their functions. As this is not ideal, is some split/cleanup to sesssion_base.php a willing cleanup ? I might be able to do this the next days. Let me know.

kerem closed this issue

2026-02-25 21:34:29 +03:00

kerem commented

2026-02-25 21:34:29 +03:00

Author

Owner

@jasonmunro commented on GitHub (Feb 8, 2018):

I'm not interested in doing this.

@jasonmunro commented on GitHub (Feb 8, 2018): I'm not interested in doing this.

kerem commented

2026-02-25 21:34:29 +03:00

Author

Owner

@Yamakasi commented on GitHub (Feb 8, 2018):

That is why I ask, shall I create PR for it ?

@Yamakasi commented on GitHub (Feb 8, 2018): That is why I ask, shall I create PR for it ?

kerem commented

2026-02-25 21:34:29 +03:00

Author

Owner

@jasonmunro commented on GitHub (Feb 8, 2018):

Please don't. I'm not interested in accepting changes to this code at this time.

@jasonmunro commented on GitHub (Feb 8, 2018): Please don't. I'm not interested in accepting changes to this code at this time.

kerem commented

2026-02-25 21:34:29 +03:00

Author

Owner

@Yamakasi commented on GitHub (Feb 8, 2018):

OK, if you say so.

@Yamakasi commented on GitHub (Feb 8, 2018): OK, if you say so.