mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 04:56:03 +03:00
[GH-ISSUE #253] 🕷 [Inline View] Moving unchecked EMails does not work #214
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#214
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ulfgebhardt on GitHub (Jan 21, 2018).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/253
Originally assigned to: @jasonmunro on GitHub.
If you have not checked the box infront of the EMail the Move Operation does nothing:
Not working:
Working fine:
Other Info
This Issue is probably an Inline View specific Issue
Rev:
34d70a0240Grüße Ulf
<3
@jasonmunro commented on GitHub (Feb 7, 2018):
Totally not surprised by this. Inline message viewing is just a big pain in the butt!
@jasonmunro commented on GitHub (Apr 16, 2018):
@ulfgebhardt Pushed a fix for this last night, let me know when you can!
@ulfgebhardt commented on GitHub (May 18, 2018):
Not fixed - still a Problem in
087402ea2a@jasonmunro commented on GitHub (Jun 6, 2018):
Confirmed that this is still not 100%. It's works sometimes, but not others. It seems that the inline message event overriding is not firing when in all cases for some reason.
@ulfgebhardt commented on GitHub (Jul 14, 2018):
Still a Problem
@jasonmunro commented on GitHub (Jul 16, 2018):
Yep, it's a race condition situation. The inline view is trying to set it's own callback event for the move feature, but sometimes the standard callback assignment happens after the inline message module, causing it to use the wrong flow and not have the right message id to move.
I worked on this friday, and almost got it sorted. Hope to this week. This is the last of the inline message view bugs I think, I'm tracking them here:
https://github.com/jasonmunro/cypht/projects/1
@jasonmunro commented on GitHub (Jul 23, 2018):
@ulfgebhardt another fix attempt pushed. Please re-test and let me know when you can. Thanks!
@jasonmunro commented on GitHub (Sep 24, 2018):
I was going to go ahead and close this but I tested it again just in case an IT WAS STILL NOT WORKING!!! At issue here is some weirdness with how the IMAP move/copy dialog works, as well as some callback hell. I now have a fix that works in all cases. Basically I'm not trying to swap callbacks and pass in the message uuid to override the checked messages anymore. Instead I'm just setting a very specific global uuid to move and when the final callback fires to actually move the message checking to see if it's set and using that instead of any other selected checkbox (and then unsetting it). I'm going to go ahead and close this now, feel free to re-open if you are still having issues. Also, I stopped the UI from scrolling to the top when a message is opened while using inline view. That was a pain! :)
I'm planning on adding some end to end tests for message and message list activities - I will include inline message view operations as a part of that effort!
@ulfgebhardt commented on GitHub (Oct 5, 2018):
Confirming fix! TY <3