mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 04:56:03 +03:00
[GH-ISSUE #237] Gmail contacts fix with max-results and Issue with national characters #201
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#201
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @szilardx on GitHub (Dec 6, 2017).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/237
Originally assigned to: @jasonmunro on GitHub.
I finally had time to debug my gmail contacts issue.
I was missing some contacts, so I tested the Google Contacts API with Postman.
I was missing some contacts there too, so I found out that to retreive all contacts, you might have to use max-results parameter. https://stackoverflow.com/questions/23960122/google-contacts-api-not-getting-all-contacts
https://developers.google.com/google-apps/contacts/v3/#retrieving_all_contacts
I appended ?max-results=500 to
github.com/jasonmunro/cypht@de5f5082df/modules/gmail_contacts/modules.php (L83)And it works. I was able to get the missing contacts in Cypht.
I also realized, that some of my contacts name is broken due to national characters being present in their contact name. Sometimes the contact name is simply missing the part after the national character. Sorry for being this national character guy.
Thank you for your work! 👍
@jasonmunro commented on GitHub (Dec 6, 2017):
I'm glad your the national character guy! I will check this out, thanks for the info
@jasonmunro commented on GitHub (Dec 6, 2017):
@szilardx just pushed a test fix, and I added the max results of 500. Let me know if it's any better for you!
@szilardx commented on GitHub (Dec 6, 2017):
@jasonmunro Thank you very much!
I have no missing contacts and all characters are okay! 👍
@jasonmunro commented on GitHub (Dec 6, 2017):
Awesome!
@dumblob commented on GitHub (Dec 7, 2017):
@jasonmunro is this a hard limit? Because I myself have over 1000 contacts and I'm certain I'm not alone. Is there a solution which does not constrain the number of contacts?
@jasonmunro commented on GitHub (Dec 8, 2017):
@dumblob lets make this an option, I will file a new ticket for that