starred/cypht

Fork 0

mirror of https://github.com/cypht-org/cypht.git synced 2026-04-25 04:56:03 +03:00

[GH-ISSUE #225] 🕷 Inline Message Delete Button does not compute #187

New issue

Closed

opened 2026-02-25 21:34:23 +03:00 by kerem · 15 comments

kerem commented

2026-02-25 21:34:23 +03:00

Owner

Originally created by @ulfgebhardt on GitHub (Sep 29, 2017).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/225

Originally assigned to: @jasonmunro on GitHub.

Hi Jason,

Inline-View works fine now!

But the Delete Button inside the EMail-Header does nothing. It popsup a confirmation, but does not delete the EMail.

Also the EMail stays open when deleted(via Button on the top) - but I consider this a nice feature, please dont remove it.

Another thing with inline messages is:

Browse to Page 2 in an EMail-Folder
Open an EMail
Press back on the Browser (Page 1 now)
Navigate to Page 2
EMail is still open - close button does not work.

Rev: 59ff05f71b

Grüße Ulf

Originally created by @ulfgebhardt on GitHub (Sep 29, 2017). Original GitHub issue: https://github.com/cypht-org/cypht/issues/225 Originally assigned to: @jasonmunro on GitHub. Hi Jason, Inline-View works fine now! But the Delete Button inside the EMail-Header does nothing. It popsup a confirmation, but does not delete the EMail. Also the EMail stays open when deleted(via Button on the top) - but I consider this a nice feature, please dont remove it. Another thing with inline messages is: 1. Browse to Page 2 in an EMail-Folder 2. Open an EMail 3. Press back on the Browser (Page 1 now) 4. Navigate to Page 2 5. EMail is still open - close button does not work. Rev: 59ff05f71bcbdbc0c9684e70b04e5ee3aa0c23e0 Grüße Ulf <3

kerem

2026-02-25 21:34:23 +03:00

closed this issue
added the
bug

inline_message
labels

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@jasonmunro commented on GitHub (Oct 13, 2017):

Just pushed a fix for this, let me know if it works for you!

@jasonmunro commented on GitHub (Oct 13, 2017): Just pushed a fix for this, let me know if it works for you!

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@ulfgebhardt commented on GitHub (Oct 14, 2017):

The second Problem was fixed.

Delete Button Problem remains:

Click the Delete Link inside the EMail
Confirm Popup
EMail closes
EMail is not deleted

Rev: 33bee91

Grüße Ulf

@ulfgebhardt commented on GitHub (Oct 14, 2017): The second Problem was fixed. Delete Button Problem remains: - Click the Delete Link inside the EMail - Confirm Popup - EMail closes - EMail is **not** deleted Rev: 33bee91 Grüße Ulf <3

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@jasonmunro commented on GitHub (Oct 14, 2017):

There are some javascript changes involved in this fix, maybe you need to force a refresh to override the cached version? I just retested and it works for me.

click delete, confirm in the popup dialog
message view is immediately removed from the display
loading bar is active
message is removed from the list
"message deleted" notice appears at the top of the page

@jasonmunro commented on GitHub (Oct 14, 2017): There are some javascript changes involved in this fix, maybe you need to force a refresh to override the cached version? I just retested and it works for me. - click delete, confirm in the popup dialog - message view is immediately removed from the display - loading bar is active - message is removed from the list - "message deleted" notice appears at the top of the page

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@ulfgebhardt commented on GitHub (Oct 14, 2017):

renamed site.js and regenerated it - no change

@ulfgebhardt commented on GitHub (Oct 14, 2017): renamed site.js and regenerated it - no change

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@jasonmunro commented on GitHub (Oct 14, 2017):

Weird. I just retested with Chrome and FIrefox, with Cypht in development and production mode, works for me in all cases. When you rerun the config_gen script, it should create a new unique id that is appended to the site.js file, which should force the browser to re-download the updated javascript. If the browser is not re-downloading the new site.js file, it could result in what you are seeing (control-shift-r will force the browser to redownload everything).

There is a bit of a delay after the message detail is removed from the page while we call the server to delete the message and the list is updated. I have been testing this in the INBOX of an IMAP account, I have not tried a combined page, maybe that is where the problem is. I will check that out now

@jasonmunro commented on GitHub (Oct 14, 2017): Weird. I just retested with Chrome and FIrefox, with Cypht in development and production mode, works for me in all cases. When you rerun the config_gen script, it should create a new unique id that is appended to the site.js file, which should force the browser to re-download the updated javascript. If the browser is not re-downloading the new site.js file, it could result in what you are seeing (control-shift-r will force the browser to redownload everything). There is a bit of a delay after the message detail is removed from the page while we call the server to delete the message and the list is updated. I have been testing this in the INBOX of an IMAP account, I have not tried a combined page, maybe that is where the problem is. I will check that out now

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@jasonmunro commented on GitHub (Oct 14, 2017):

Yep, that's the problem. works on normal IMAP folder views, but not combined pages. Looking into it now!

@jasonmunro commented on GitHub (Oct 14, 2017): Yep, that's the problem. works on normal IMAP folder views, but not combined pages. Looking into it now!

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@ulfgebhardt commented on GitHub (Oct 14, 2017):

Oh, im sorry i didnt mentioned that im on "Everything" with 5 accounts. I also sent you an EMail with another Problem I have which requires private Info to properly test. If you want i can record you a video for the delete button thing and send you a link via mail.

I can confirm that there is a new token generated when the site is "recompiled"

@ulfgebhardt commented on GitHub (Oct 14, 2017): Oh, im sorry i didnt mentioned that im on "Everything" with 5 accounts. I also sent you an EMail with another Problem I have which requires private Info to properly test. If you want i can record you a video for the delete button thing and send you a link via mail. I can confirm that there is a new token generated when the site is "recompiled"

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@jasonmunro commented on GitHub (Oct 14, 2017):

Just responded to your Email, and pushed a fix for that issue. The problem with the delete link is definitely related to combined views vs an IMAP folder page. I have found the code that is failing, I just need to work up a fix :)

@jasonmunro commented on GitHub (Oct 14, 2017): Just responded to your Email, and pushed a fix for that issue. The problem with the delete link is definitely related to combined views vs an IMAP folder page. I have found the code that is failing, I just need to work up a fix :)

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@ItsEcholot commented on GitHub (Nov 13, 2017):

Just stumbled upon the delete issue as well, good to know that a fix is in the works.

@ItsEcholot commented on GitHub (Nov 13, 2017): Just stumbled upon the delete issue as well, good to know that a fix is in the works.

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@ulfgebhardt commented on GitHub (Jan 5, 2018):

Bug still present in

Rev: ed4cd35
Rev: 34d70a0240

I think it works properly on mobile tho

Grüße Ulf

@ulfgebhardt commented on GitHub (Jan 5, 2018): Bug still present in Rev: ed4cd35 Rev: 34d70a0240c10b6b8ab9fedf7c96cf8a0ef0ed53 I think it works properly on mobile tho Grüße Ulf <3

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@jasonmunro commented on GitHub (Apr 16, 2018):

This should be finally fixed! :)

@jasonmunro commented on GitHub (Apr 16, 2018): This should be finally fixed! :)

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@ulfgebhardt commented on GitHub (May 18, 2018):

<3 ur the best!

@ulfgebhardt commented on GitHub (May 18, 2018): <3 ur the best!

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@ulfgebhardt commented on GitHub (May 25, 2018):

If the checkbox infront of the Mail is selected the delete button does not work - if its unchecked it does.

Message
-> Inline DeleteButton -> does not work
Message
-> Inline DeleteButton -> does work

@ulfgebhardt commented on GitHub (May 25, 2018): If the checkbox infront of the Mail is selected the delete button does not work - if its unchecked it does. - [X] Message -> Inline DeleteButton -> does not work - [ ] Message -> Inline DeleteButton -> does work

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@jasonmunro commented on GitHub (Jun 6, 2018):

another fix is pushed. The easiest way to handle this was to simply uncheck the checkbox before delete :)

@jasonmunro commented on GitHub (Jun 6, 2018): another fix is pushed. The easiest way to handle this was to simply uncheck the checkbox before delete :)

kerem commented

2026-02-25 21:34:23 +03:00

Author

Owner

@ulfgebhardt commented on GitHub (Jul 14, 2018):

Confirming fix <3

@ulfgebhardt commented on GitHub (Jul 14, 2018): Confirming fix <3