[GH-ISSUE #195] Normal functioning? #160

Closed
opened 2026-02-25 21:34:19 +03:00 by kerem · 2 comments
Owner

Originally created by @mwolfeu on GitHub (May 14, 2017).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/195

Originally assigned to: @jasonmunro on GitHub.

I have:
auth_type=dynamic
but accidentally left in:
; modules[]=dynamic_login

Regardless, I can type in a new user name/password in a browser and save it in a text file. Is this intended?

Originally created by @mwolfeu on GitHub (May 14, 2017). Original GitHub issue: https://github.com/cypht-org/cypht/issues/195 Originally assigned to: @jasonmunro on GitHub. I have: auth_type=dynamic but accidentally left in: ; modules[]=dynamic_login Regardless, I can type in a new user name/password in a browser and save it in a text file. Is this intended?
kerem 2026-02-25 21:34:19 +03:00
Author
Owner

@jasonmunro commented on GitHub (May 15, 2017):

If you set the auth_type to dynamic, and you don't activate the module, it uses the "Auth type none" class (which really only exists for unit tests), that returns true for any username/password combination. This is a bug IMO. We should just "die" like we do for other misconfigured authentication configurations. Thanks for this feedback!

<!-- gh-comment-id:301623737 --> @jasonmunro commented on GitHub (May 15, 2017): If you set the auth_type to dynamic, and you don't activate the module, it uses the "Auth type none" class (which really only exists for unit tests), that returns true for any username/password combination. This is a bug IMO. We should just "die" like we do for other misconfigured authentication configurations. Thanks for this feedback!
Author
Owner

@jasonmunro commented on GitHub (May 15, 2017):

Fixed in github.com/jasonmunro/cypht@40ca661d43 thanks again!

<!-- gh-comment-id:301629908 --> @jasonmunro commented on GitHub (May 15, 2017): Fixed in https://github.com/jasonmunro/cypht/commit/40ca661d436ded01c4731f13220cab13d95c5467 thanks again!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#160
No description provided.