[PR #1471] [CLOSED] fix(frontend): only check sieve block lists if sieve module is enabled #1539

New issue

Closed

opened 2026-02-25 21:38:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:38:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1471
Author: @indridieinarsson
Created: 3/13/2025
Status: ❌ Closed

Base: master ← Head: pr_fix_sieve

📝 Commits (1)

054dd3a Only check sieve block lists if sieve module is enabled

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 modules/core/js_modules/route_handlers.js (+3 -1)

📄 Description

🍰 Pullrequest

Javascript code is calling ajax_list_block_sieve on page load (on combined_inbox at least), even if I don't have sievefilters module enabled. This causes an error in the backend ('not callable'), since the sieve stuff isn't available. This in turn gives rise to an error message on the web gui, each time the site is reloaded.

This PR makes sure this isn't called unless the module is enabled.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1471 **Author:** [@indridieinarsson](https://github.com/indridieinarsson) **Created:** 3/13/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `pr_fix_sieve` --- ### 📝 Commits (1) - [`054dd3a`](https://github.com/cypht-org/cypht/commit/054dd3a1553dcde99331519d4e33b0020159b83c) Only check sieve block lists if sieve module is enabled ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/js_modules/route_handlers.js` (+3 -1) </details> ### 📄 Description ## 🍰 Pullrequest Javascript code is calling `ajax_list_block_sieve` on page load (on combined_inbox at least), even if I don't have sievefilters module enabled. This causes an error in the backend ('not callable'), since the sieve stuff isn't available. This in turn gives rise to an error message on the web gui, each time the site is reloaded. This PR makes sure this isn't called unless the module is enabled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>