starred/cypht
1
0
Fork 0
mirror of https://github.com/cypht-org/cypht.git synced 2026-04-24 20:46:04 +03:00
Code Issues 137 Projects Releases Packages Wiki Activity

[PR #1443] [MERGED] fix(frontend/backend): address all blocking issues #1518

New issue
Closed
opened 2026-02-25 21:38:31 +03:00 by kerem · 0 comments
kerem commented 2026-02-25 21:38:31 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1443
Author: @mercihabam
Created: 2/10/2025
Status: ✅ Merged
Merged: 2/17/2025
Merged by: @mercihabam

Base: master ← Head: some-fixes

📝 Commits (10+)

  • 61e13f7 fix(frontend): prevent Cypht-related mobile nav CSS attributes from overriding third-party styles
  • b21698a fix(backend): showing server sieve capabilities
  • 6be91eb fix(frontend): git revision link not opening the remote url
  • cf817e0 fix(frontend): fadeOutAndRemove should not only be extended to cash but also to jQuery
  • 7636fe7 fix(frontend): refresh ui state when adding a server
  • 41e6a86 fix(backend): adding accounts via files imports
  • 8ebf605 fix(backend): downloading server accounts sample files in third-party softwares
  • 793ae85 fix elements spacing of the search page
  • 76965fe fix(backend): offline error message when hihandling a message action or deleting a folder
  • e694211 fix(frontend): hide the refresh icon on the search page as it's replaced by the update button

📊 Changes

29 files changed (+205 additions, -120 deletions)

View changed files

📝 assets/data/server_accounts_sample.csv (+0 -0)
📝 assets/data/server_accounts_sample.yaml (+0 -0)
📝 index.php (+1 -0)
📝 modules/core/js_modules/Hm_MessagesStore.js (+13 -2)
📝 modules/core/js_modules/[cash]/extend.js (+0 -8)
📝 modules/core/js_modules/actions/pagination.js (+4 -4)
📝 modules/core/js_modules/actions/sortCombinedLists.js (+3 -3)
📝 modules/core/js_modules/route_handlers.js (+1 -1)
📝 modules/core/js_modules/utils/sortable.js (+2 -2)
📝 modules/core/message_list_functions.php (+2 -2)
📝 modules/core/navigation/navigation.js (+6 -2)
📝 modules/core/navigation/utils.js (+7 -6)
📝 modules/core/site.css (+20 -4)
📝 modules/core/site.js (+30 -11)
📝 modules/developer/modules.php (+1 -1)
📝 modules/github/js_modules/route_handlers.js (+2 -2)
📝 modules/imap/functions.php (+2 -2)
📝 modules/imap/handler_modules.php (+31 -8)
📝 modules/imap/js_modules/route_handlers.js (+5 -3)
📝 modules/imap/site.js (+44 -33)

...and 9 more files

📄 Description

In tandem with: https://gitlab.com/tikiwiki/tiki/-/merge_requests/6934

  • The filter component on mobile overlaps the content title
  • The Tiki bottom menu is mostly hidden from the left side
  • Errors “could not perform action…” when navigating to the info page
  • Git revision raises failed to fetch
  • Removing an imap/smtp server does not show it as deleted
  • Add an email, the label “Select an E-mail provider” is below the select element. This is also the case for the folders page
  • Adding a server does not refresh the state
  • Import accounts using yaml/csv file - Downloading a sample fails with the message “File wasn’t available on site”
  • Search page. Select filters do not occupy enough space for their content to be readable.
  • Selecting an email row from the search page, the actions component pops over the content title, making the whole thing unreadable.
  • When hitting the action “Read/Unread/Flag/Archive/Delete” the offline error is shown and the action is undone visually. This also happens when deleting a folder.
  • The refresh button on the search page does not do anything.
  • Deleting saved searches does not work
  • Saving a draft message shows the offline error
  • Listing message in the draft folder shows the offline error
  • Everything/Junk/Flagged/Sent/Snoozed/Trash/Unread view as well.
  • After performing a search in a folder, navigating between the paginated results, and then clearing the search, the pages keep the lists from the search result.
  • When filtering between read/unread/flagged/… the paginated lists do not get updated.
  • When opening an unread message, the counter does not get updated.
  • Message view - create tracker item/move to tracker does not do anything unless the window is reloaded
  • Snooze - Pick a date does not show a date picker
  • Deleting a message reloads the browser to the next message, but the prev button shows the title of the previously deleted message
  • The search page on mobile does not fully show the filter inputs
  • Server status and capabilities not shown
  • Failure when navigating to the filters page
  • A bunch of errors “Sieve: Error while trying to connect to ManageSieve” when navigating to the blocklist page (They are legitimate because they warn the user that Sieve is not authenticated).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1443 **Author:** [@mercihabam](https://github.com/mercihabam) **Created:** 2/10/2025 **Status:** ✅ Merged **Merged:** 2/17/2025 **Merged by:** [@mercihabam](https://github.com/mercihabam) **Base:** `master` ← **Head:** `some-fixes` --- ### 📝 Commits (10+) - [`61e13f7`](https://github.com/cypht-org/cypht/commit/61e13f770fca0bec38e308b81bce11f29b6a8671) fix(frontend): prevent Cypht-related mobile nav CSS attributes from overriding third-party styles - [`b21698a`](https://github.com/cypht-org/cypht/commit/b21698ae3a7852ac31a44cebd0a1460f0a47b9cf) fix(backend): showing server sieve capabilities - [`6be91eb`](https://github.com/cypht-org/cypht/commit/6be91eb6cc33e4a1063c6d62303223492507a839) fix(frontend): git revision link not opening the remote url - [`cf817e0`](https://github.com/cypht-org/cypht/commit/cf817e07b87da9947aeb549a4f16485f340e10ce) fix(frontend): fadeOutAndRemove should not only be extended to cash but also to jQuery - [`7636fe7`](https://github.com/cypht-org/cypht/commit/7636fe70fd9c0d69dd112f76f1e9f8a1e704f508) fix(frontend): refresh ui state when adding a server - [`41e6a86`](https://github.com/cypht-org/cypht/commit/41e6a8608eed681432c9080022e78fb4bcbddd19) fix(backend): adding accounts via files imports - [`8ebf605`](https://github.com/cypht-org/cypht/commit/8ebf605230cf6d99b24cb16a133b6cd19f8d72d4) fix(backend): downloading server accounts sample files in third-party softwares - [`793ae85`](https://github.com/cypht-org/cypht/commit/793ae85e9b693d4f264eb8d09dd3b14941964148) fix elements spacing of the search page - [`76965fe`](https://github.com/cypht-org/cypht/commit/76965fedb471de3a666bbf44a8b6e565c0ff3453) fix(backend): offline error message when hihandling a message action or deleting a folder - [`e694211`](https://github.com/cypht-org/cypht/commit/e694211034c7e3a20226f9c821062c3bb4349f52) fix(frontend): hide the refresh icon on the search page as it's replaced by the update button ### 📊 Changes **29 files changed** (+205 additions, -120 deletions) <details> <summary>View changed files</summary> 📝 `assets/data/server_accounts_sample.csv` (+0 -0) 📝 `assets/data/server_accounts_sample.yaml` (+0 -0) 📝 `index.php` (+1 -0) 📝 `modules/core/js_modules/Hm_MessagesStore.js` (+13 -2) 📝 `modules/core/js_modules/[cash]/extend.js` (+0 -8) 📝 `modules/core/js_modules/actions/pagination.js` (+4 -4) 📝 `modules/core/js_modules/actions/sortCombinedLists.js` (+3 -3) 📝 `modules/core/js_modules/route_handlers.js` (+1 -1) 📝 `modules/core/js_modules/utils/sortable.js` (+2 -2) 📝 `modules/core/message_list_functions.php` (+2 -2) 📝 `modules/core/navigation/navigation.js` (+6 -2) 📝 `modules/core/navigation/utils.js` (+7 -6) 📝 `modules/core/site.css` (+20 -4) 📝 `modules/core/site.js` (+30 -11) 📝 `modules/developer/modules.php` (+1 -1) 📝 `modules/github/js_modules/route_handlers.js` (+2 -2) 📝 `modules/imap/functions.php` (+2 -2) 📝 `modules/imap/handler_modules.php` (+31 -8) 📝 `modules/imap/js_modules/route_handlers.js` (+5 -3) 📝 `modules/imap/site.js` (+44 -33) _...and 9 more files_ </details> ### 📄 Description In tandem with: https://gitlab.com/tikiwiki/tiki/-/merge_requests/6934 - [x] The filter component on mobile overlaps the content title - [x] The Tiki bottom menu is mostly hidden from the left side - [x] Errors “could not perform action…” when navigating to the info page - [x] Git revision raises failed to fetch - [x] Removing an imap/smtp server does not show it as deleted - [x] Add an email, the label “Select an E-mail provider” is below the select element. This is also the case for the folders page - [x] Adding a server does not refresh the state - [x] Import accounts using yaml/csv file - Downloading a sample fails with the message “File wasn’t available on site” - [x] Search page. Select filters do not occupy enough space for their content to be readable. - [x] Selecting an email row from the search page, the actions component pops over the content title, making the whole thing unreadable. - [x] When hitting the action “Read/Unread/Flag/Archive/Delete” the offline error is shown and the action is undone visually. This also happens when deleting a folder. - [x] The refresh button on the search page does not do anything. - [x] Deleting saved searches does not work - [x] Saving a draft message shows the offline error - [x] Listing message in the draft folder shows the offline error - [x] Everything/Junk/Flagged/Sent/Snoozed/Trash/Unread view as well. - [x] After performing a search in a folder, navigating between the paginated results, and then clearing the search, the pages keep the lists from the search result. - [x] When filtering between read/unread/flagged/… the paginated lists do not get updated. - [x] When opening an unread message, the counter does not get updated. - [x] Message view - create tracker item/move to tracker does not do anything unless the window is reloaded - [x] Snooze - Pick a date does not show a date picker - [x] Deleting a message reloads the browser to the next message, but the prev button shows the title of the previously deleted message - [x] The search page on mobile does not fully show the filter inputs - [x] Server status and capabilities not shown - [x] Failure when navigating to the filters page - [x] ~~A bunch of errors “Sieve: Error while trying to connect to ManageSieve” when navigating to the blocklist page~~ (They are legitimate because they warn the user that Sieve is not authenticated). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:38:31 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
2.x
mta-sts-implementation
feat-compose-backspace-delete-recipients
release-2.5.1
add-tls3-support
1.4.x
enforce-coverage
release-2.4.2
strip_dns_prefetch_tags
fix_nightly_build
pr-title-validation-update
review-sent-email
revert-1339-fixed-tags-display
revert-1061-rem-cram-md5
sys-messages-revamp
revert-685-fixed-str-pos-warning-when-no-to
revert-590-empty-settings
release-1.3.0
revert-471-draft-add-warning
revert-454-feature/server-list-by-uniqid
php7.4-support
release-1.2.0
remove-mobile-media-queries
release-1.1.0
release-1.0.0
v2.7.0
v2.6.0
v2.5.1
v2.5.0
v1.4.7
v2.4.2
v2.4.1
v1.4.6
v1.4.5
v2.4.0
v2.3.0
v2.2.0
v1.4.4
v2.1.0
v2.0.1
v1.4.3
v2.0.0
v1.4.2
v1.4.1
v1.4.0
v1.3.0
v1.3.0-rc3
v1.3.0-rc2
v1.3.0-rc1
v1.1.0
v1.1.0-rc4
v1.1.0-rc3
v1.1.0-rc2
v1.1.0-rc1
v1.0.0
v1.0.0-rc8
v1.0.0-rc7
v1.0.0-rc6
v1.0.0-rc5
v1.0.0-rc4
v1.0.0-rc3
v1.0.0-rc2
v1.0.0-rc1
Labels
Clear labels   
2fa

   
I18N

   
PGP

   
Security

   
Security

   
account

   
advanced_search

   
advanced_search

   
announcement

   
api_login

   
authentication

   
awaiting feedback

   
blocker

   
bug

   
bug

   
bug

   
calendar

   
config

   
contacts

   
core

   
core

   
devops

   
docker

   
docs

   
duplicate

   
dynamic_login

   
enhancement

   
epic

   
feature

   
feeds

   
framework

   
github

   
github

   
gmail_contacts

   
good first issue

   
help wanted

   
history

   
history

   
imap

   
imap_folders

   
inline_message

   
installation

   
keyboard_shortcuts

   
keyboard_shortcuts

   
ldap_contacts

   
mobile

   
need-ssh-access

   
new module set

   
nux

   
pop3

   
profiles

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
refactor

   
release

   
research

   
saved_searches

   
smtp

   
strategic

   
tags

   
tests

   
themes

   
website

   
wordpress
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#1518
No description provided.