[PR #1388] [MERGED] Map new message identifiers to all existing entries (from the Tags repository & the client message cache storage) of the same message when it is moved #1476

New issue

Closed

opened 2026-02-25 21:38:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:38:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1388
Author: @mercihabam
Created: 11/26/2024
Status: ✅ Merged
Merged: 11/27/2024
Merged by: @mercihabam

Base: master ← Head: enh-move-action

📝 Commits (5)

d76fb4e Map new message identifiers to all existing entries (from the Tags repository & the client message cache storage) of the same message when it is moved
806d42a Refacor every usage of the "$imap->message_action()" to the new return type
4cd0996 Sync the Tag Repository when moving a message to a different server
e0da724 Fix the move_responses when moving messages in a batch
8c68640 Update the messages store when after a move operation

📊 Changes

13 files changed (+226 additions, -54 deletions)

View changed files

📝 modules/core/js_modules/Hm_MessagesStore.js (+11 -0)
📝 modules/core/js_modules/utils/sortable.js (+8 -5)
📝 modules/core/navigation/utils.js (+1 -1)
📝 modules/imap/functions.php (+51 -15)
📝 modules/imap/handler_modules.php (+20 -11)
📝 modules/imap/hm-imap.php (+31 -8)
📝 modules/imap/setup.php (+1 -0)
📝 modules/imap/site.js (+8 -2)
📝 modules/smtp/modules.php (+1 -1)
📝 modules/tags/handler_modules.php (+17 -0)
📝 modules/tags/hm-tags.php (+62 -0)
📝 modules/tags/setup.php (+4 -0)
📝 tests/phpunit/modules/imap/hm_imap.php (+11 -11)

📄 Description

TODO:

The Tags repository works so far only when a message is moved to a different folder within the same IMAP server. This should also work when the server changes.
The client storage key of the moved messages should be updated as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1388 **Author:** [@mercihabam](https://github.com/mercihabam) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 11/27/2024 **Merged by:** [@mercihabam](https://github.com/mercihabam) **Base:** `master` ← **Head:** `enh-move-action` --- ### 📝 Commits (5) - [`d76fb4e`](https://github.com/cypht-org/cypht/commit/d76fb4e3a33ec29b676a6db93910f53576f8a03a) Map new message identifiers to all existing entries (from the Tags repository & the client message cache storage) of the same message when it is moved - [`806d42a`](https://github.com/cypht-org/cypht/commit/806d42a126b1c207c4c69edd647dda207e413260) Refacor every usage of the "$imap->message_action()" to the new return type - [`4cd0996`](https://github.com/cypht-org/cypht/commit/4cd09969e0335b5888839c516776097399b7c8f3) Sync the Tag Repository when moving a message to a different server - [`e0da724`](https://github.com/cypht-org/cypht/commit/e0da724c375f8f3ca84dc21b44bdb0ee0e4e4b3c) Fix the move_responses when moving messages in a batch - [`8c68640`](https://github.com/cypht-org/cypht/commit/8c686404c2b6370a7ed86e43a1bea9866aa89107) Update the messages store when after a move operation ### 📊 Changes **13 files changed** (+226 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/js_modules/Hm_MessagesStore.js` (+11 -0) 📝 `modules/core/js_modules/utils/sortable.js` (+8 -5) 📝 `modules/core/navigation/utils.js` (+1 -1) 📝 `modules/imap/functions.php` (+51 -15) 📝 `modules/imap/handler_modules.php` (+20 -11) 📝 `modules/imap/hm-imap.php` (+31 -8) 📝 `modules/imap/setup.php` (+1 -0) 📝 `modules/imap/site.js` (+8 -2) 📝 `modules/smtp/modules.php` (+1 -1) 📝 `modules/tags/handler_modules.php` (+17 -0) 📝 `modules/tags/hm-tags.php` (+62 -0) 📝 `modules/tags/setup.php` (+4 -0) 📝 `tests/phpunit/modules/imap/hm_imap.php` (+11 -11) </details> ### 📄 Description TODO: - [x] The Tags repository works so far only when a message is moved to a different folder within the same IMAP server. This should also work when the server changes. - [x] The client storage key of the moved messages should be updated as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>