[PR #1358] [MERGED] Fix the sieve filters page which is duplicating the modal content #1452

New issue

Closed

opened 2026-02-25 21:38:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:38:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1358
Author: @mercihabam
Created: 11/17/2024
Status: ✅ Merged
Merged: 11/18/2024
Merged by: @mercihabam

Base: master ← Head: fix-filters-page

📝 Commits (3)

9f3a51b Fix the sieve filters page which is duplicating the modal content
cbd7c34 Fix selenium tests: the navigation should be awaited for only if the expected route isn't yet active
582ee88 Deal with flaky tests

📊 Changes

7 files changed (+27 additions, -663 deletions)

View changed files

📝 modules/core/navigation/navigation.js (+4 -1)
📝 modules/core/site.js (+7 -1)
📝 modules/sievefilters/js_modules/route_handlers.js (+4 -0)
📝 modules/sievefilters/site.js (+5 -657)
📝 tests/selenium/folder_list.py (+2 -1)
📝 tests/selenium/profiles.py (+1 -1)
📝 tests/selenium/settings.py (+4 -2)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1358 **Author:** [@mercihabam](https://github.com/mercihabam) **Created:** 11/17/2024 **Status:** ✅ Merged **Merged:** 11/18/2024 **Merged by:** [@mercihabam](https://github.com/mercihabam) **Base:** `master` ← **Head:** `fix-filters-page` --- ### 📝 Commits (3) - [`9f3a51b`](https://github.com/cypht-org/cypht/commit/9f3a51b9acf4b374a48e409bf005bab65c6a1208) Fix the sieve filters page which is duplicating the modal content - [`cbd7c34`](https://github.com/cypht-org/cypht/commit/cbd7c345c2c30c9e028ac00b14b1f966dbf9d1fc) Fix selenium tests: the navigation should be awaited for only if the expected route isn't yet active - [`582ee88`](https://github.com/cypht-org/cypht/commit/582ee882809509f18170fb1ede93a04f54dec18a) Deal with flaky tests ### 📊 Changes **7 files changed** (+27 additions, -663 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/navigation/navigation.js` (+4 -1) 📝 `modules/core/site.js` (+7 -1) 📝 `modules/sievefilters/js_modules/route_handlers.js` (+4 -0) 📝 `modules/sievefilters/site.js` (+5 -657) 📝 `tests/selenium/folder_list.py` (+2 -1) 📝 `tests/selenium/profiles.py` (+1 -1) 📝 `tests/selenium/settings.py` (+4 -2) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>