[PR #1331] [MERGED] make sieve data format automatic on connect #1437

Closed
opened 2026-02-25 21:38:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1331
Author: @Shadow243
Created: 11/11/2024
Status: Merged
Merged: 11/18/2024
Merged by: @kroky

Base: masterHead: automate-sieve-host-based-on-nux-modules


📝 Commits (1)

  • 9d21016 make sieve data format automatic on connect

📊 Changes

5 files changed (+44 additions, -18 deletions)

View changed files

📝 modules/imap/functions.php (+1 -1)
📝 modules/nux/modules.php (+4 -0)
📝 modules/sievefilters/functions.php (+20 -4)
📝 modules/sievefilters/hm-sieve.php (+8 -2)
📝 modules/sievefilters/modules.php (+11 -11)

📄 Description

Related comment from @marclaporte : https://avan.tech/item119173#threadId81209

To support both Cypht 1.4 (which uses tls:// prefixes for Sieve hostnames) and newer versions (which omit tls://), we’ve implemented an automated way to determine the correct Sieve hostname format using Nux_Quick_Services. Here's how it works:

  1. Automatic Host Detection: The code checks Nux_Quick_Services to retrieve the correct Sieve host for each service. For example, for migadu, it will use domain.com:port.

  2. Version Compatibility: If the running version is Cypht 1.4, it will prepend tls:// to the hostname (e.g., tls://domain.com:port). For newer versions, it uses the plain hostname format (domain.com:port).

  3. Seamless Integration: This ensures compatibility with both Cypht 1.4 and newer versions without manual configuration changes, reducing user setup errors and simplifying support.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1331 **Author:** [@Shadow243](https://github.com/Shadow243) **Created:** 11/11/2024 **Status:** ✅ Merged **Merged:** 11/18/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `automate-sieve-host-based-on-nux-modules` --- ### 📝 Commits (1) - [`9d21016`](https://github.com/cypht-org/cypht/commit/9d21016cf59e9e3dbba18b5942a21b888a877534) make sieve data format automatic on connect ### 📊 Changes **5 files changed** (+44 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `modules/imap/functions.php` (+1 -1) 📝 `modules/nux/modules.php` (+4 -0) 📝 `modules/sievefilters/functions.php` (+20 -4) 📝 `modules/sievefilters/hm-sieve.php` (+8 -2) 📝 `modules/sievefilters/modules.php` (+11 -11) </details> ### 📄 Description Related comment from @marclaporte : https://avan.tech/item119173#threadId81209 To support both Cypht 1.4 (which uses `tls://` prefixes for Sieve hostnames) and newer versions (which omit `tls://`), we’ve implemented an automated way to determine the correct Sieve hostname format using `Nux_Quick_Services`. Here's how it works: 1. **Automatic Host Detection**: The code checks `Nux_Quick_Services` to retrieve the correct Sieve host for each service. For example, for `migadu`, it will use `domain.com:port`. 2. **Version Compatibility**: If the running version is Cypht 1.4, it will prepend `tls://` to the hostname (e.g., `tls://domain.com:port`). For newer versions, it uses the plain hostname format (`domain.com:port`). 3. **Seamless Integration**: This ensures compatibility with both Cypht 1.4 and newer versions without manual configuration changes, reducing user setup errors and simplifying support. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:38:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#1437
No description provided.