mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 04:56:03 +03:00
[PR #1331] [MERGED] make sieve data format automatic on connect #1437
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#1437
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/cypht-org/cypht/pull/1331
Author: @Shadow243
Created: 11/11/2024
Status: ✅ Merged
Merged: 11/18/2024
Merged by: @kroky
Base:
master← Head:automate-sieve-host-based-on-nux-modules📝 Commits (1)
9d21016make sieve data format automatic on connect📊 Changes
5 files changed (+44 additions, -18 deletions)
View changed files
📝
modules/imap/functions.php(+1 -1)📝
modules/nux/modules.php(+4 -0)📝
modules/sievefilters/functions.php(+20 -4)📝
modules/sievefilters/hm-sieve.php(+8 -2)📝
modules/sievefilters/modules.php(+11 -11)📄 Description
Related comment from @marclaporte : https://avan.tech/item119173#threadId81209
To support both Cypht 1.4 (which uses
tls://prefixes for Sieve hostnames) and newer versions (which omittls://), we’ve implemented an automated way to determine the correct Sieve hostname format usingNux_Quick_Services. Here's how it works:Automatic Host Detection: The code checks
Nux_Quick_Servicesto retrieve the correct Sieve host for each service. For example, formigadu, it will usedomain.com:port.Version Compatibility: If the running version is Cypht 1.4, it will prepend
tls://to the hostname (e.g.,tls://domain.com:port). For newer versions, it uses the plain hostname format (domain.com:port).Seamless Integration: This ensures compatibility with both Cypht 1.4 and newer versions without manual configuration changes, reducing user setup errors and simplifying support.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.