[PR #1313] [MERGED] Tweak the sidebar for a modern look and feel #1426

Closed
opened 2026-02-25 21:38:14 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1313
Author: @mercihabam
Created: 11/2/2024
Status: Merged
Merged: 11/5/2024
Merged by: @mercihabam

Base: masterHead: tweak-sidebar


📝 Commits (9)

  • 95d3fd3 Tweak the sidebar for a modern look and feel
  • a0e3a27 Many adjustments, including: using the bootstrap collapse components for collapsible items in the navbar, the sizing, and a bit on the look
  • ae3d08a Adjust unit tests
  • 384e897 Adjust selenium tests
  • 3b78588 Fix selenium tests
  • c01afce Fix folder_list tests
  • 4da00cd Fix profiles tests
  • e25d810 Fix settings tests
  • 5a3eede Fix servers tests

📊 Changes

26 files changed (+147 additions, -123 deletions)

View changed files

📝 modules/account/modules.php (+1 -1)
📝 modules/calendar/modules.php (+1 -1)
📝 modules/contacts/modules.php (+1 -1)
📝 modules/core/output_modules.php (+29 -32)
📝 modules/core/site.css (+32 -24)
📝 modules/core/site.js (+12 -14)
📝 modules/developer/modules.php (+2 -2)
📝 modules/feeds/modules.php (+4 -4)
📝 modules/history/modules.php (+1 -1)
📝 modules/imap_folders/modules.php (+1 -1)
📝 modules/keyboard_shortcuts/modules.php (+1 -1)
📝 modules/pgp/modules.php (+1 -1)
📝 modules/profiles/modules.php (+1 -1)
📝 modules/smtp/modules.php (+2 -2)
📝 modules/tags/modules.php (+1 -1)
📝 tests/phpunit/modules/core/output_modules.php (+12 -12)
📝 tests/phpunit/modules/core/output_modules_debug.php (+2 -2)
📝 tests/selenium/base.py (+11 -1)
📝 tests/selenium/folder_list.py (+15 -11)
📝 tests/selenium/login.py (+1 -0)

...and 6 more files

📄 Description

Further enhancements could be made. If anyone would like to help, the following points need attention:

  • Content such as the changes notice button, debug mode, and logout button are misplaced. (Handled by #1397)
  • The link to the home page should not be in the sidebar as an item, instead, it should be accessible via the app logo. (Handled by #1397)
  • The hide folders icon down in the sidebar, should not be present on mobile viewports. On desktop screens, it has to be replaced by something similar to the menu toggle button on mobile screens. (Handled by #1347)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1313 **Author:** [@mercihabam](https://github.com/mercihabam) **Created:** 11/2/2024 **Status:** ✅ Merged **Merged:** 11/5/2024 **Merged by:** [@mercihabam](https://github.com/mercihabam) **Base:** `master` ← **Head:** `tweak-sidebar` --- ### 📝 Commits (9) - [`95d3fd3`](https://github.com/cypht-org/cypht/commit/95d3fd33bfd84dda415fec203189d1072d8df76b) Tweak the sidebar for a modern look and feel - [`a0e3a27`](https://github.com/cypht-org/cypht/commit/a0e3a27c6e8025a9949f279beb14f6ffc5269784) Many adjustments, including: using the bootstrap collapse components for collapsible items in the navbar, the sizing, and a bit on the look - [`ae3d08a`](https://github.com/cypht-org/cypht/commit/ae3d08ad974f31d2077c3f844125b330d7d4d3c7) Adjust unit tests - [`384e897`](https://github.com/cypht-org/cypht/commit/384e8979f9eda1076a3a5afd86532571b2fd5974) Adjust selenium tests - [`3b78588`](https://github.com/cypht-org/cypht/commit/3b7858807ec94c2f663fc1aee06c41de4a556355) Fix selenium tests - [`c01afce`](https://github.com/cypht-org/cypht/commit/c01afce6ad9e9ad34e7db0b8234ccd25636c6917) Fix folder_list tests - [`4da00cd`](https://github.com/cypht-org/cypht/commit/4da00cd207144c8b6c53ea920c8836184b863e18) Fix profiles tests - [`e25d810`](https://github.com/cypht-org/cypht/commit/e25d8108e7f3a6c4d503571d70e9837eb4b27baf) Fix settings tests - [`5a3eede`](https://github.com/cypht-org/cypht/commit/5a3eede37ea58bfe3e50859ca154ac3ff0e4c0b3) Fix servers tests ### 📊 Changes **26 files changed** (+147 additions, -123 deletions) <details> <summary>View changed files</summary> 📝 `modules/account/modules.php` (+1 -1) 📝 `modules/calendar/modules.php` (+1 -1) 📝 `modules/contacts/modules.php` (+1 -1) 📝 `modules/core/output_modules.php` (+29 -32) 📝 `modules/core/site.css` (+32 -24) 📝 `modules/core/site.js` (+12 -14) 📝 `modules/developer/modules.php` (+2 -2) 📝 `modules/feeds/modules.php` (+4 -4) 📝 `modules/history/modules.php` (+1 -1) 📝 `modules/imap_folders/modules.php` (+1 -1) 📝 `modules/keyboard_shortcuts/modules.php` (+1 -1) 📝 `modules/pgp/modules.php` (+1 -1) 📝 `modules/profiles/modules.php` (+1 -1) 📝 `modules/smtp/modules.php` (+2 -2) 📝 `modules/tags/modules.php` (+1 -1) 📝 `tests/phpunit/modules/core/output_modules.php` (+12 -12) 📝 `tests/phpunit/modules/core/output_modules_debug.php` (+2 -2) 📝 `tests/selenium/base.py` (+11 -1) 📝 `tests/selenium/folder_list.py` (+15 -11) 📝 `tests/selenium/login.py` (+1 -0) _...and 6 more files_ </details> ### 📄 Description Further enhancements could be made. If anyone would like to help, the following points need attention: - [x] Content such as the changes notice button, debug mode, and logout button are misplaced. (Handled by #1397) - [x] The link to the home page should not be in the sidebar as an item, instead, it should be accessible via the app logo. (Handled by #1397) - [x] The hide folders icon down in the sidebar, should not be present on mobile viewports. On desktop screens, it has to be replaced by something similar to the menu toggle button on mobile screens. (Handled by #1347) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:38:14 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#1426
No description provided.