[PR #1311] [MERGED] Removed forget/save actions #1424

New issue

Closed

opened 2026-02-25 21:38:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:38:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1311
Author: @josaphatim
Created: 11/1/2024
Status: ✅ Merged
Merged: 11/4/2024
Merged by: @kroky

Base: master ← Head: removed-save-forgot-server-buttons

📝 Commits (1)

b34489d Removed forget/save actions

📊 Changes

8 files changed (+28 additions, -298 deletions)

View changed files

📝 modules/imap/handler_modules.php (+10 -114)
📝 modules/imap/output_modules.php (+0 -4)
📝 modules/imap/setup.php (+0 -4)
📝 modules/imap/site.js (+3 -49)
📝 modules/imap_folders/modules.php (+4 -4)
📝 modules/smtp/modules.php (+8 -70)
📝 modules/smtp/setup.php (+0 -4)
📝 modules/smtp/site.js (+3 -49)

📄 Description

This PR removes server forget/save buttons in favor of edit button.
The context is that many fields are being added on server page (lately sieve_tls) and others may come. The forget/save cannot handle these in the future. Edit button instead allows users to edit all together SMTP and IMAP + Sieve with all the fields.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1311 **Author:** [@josaphatim](https://github.com/josaphatim) **Created:** 11/1/2024 **Status:** ✅ Merged **Merged:** 11/4/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `removed-save-forgot-server-buttons` --- ### 📝 Commits (1) - [`b34489d`](https://github.com/cypht-org/cypht/commit/b34489da9832a77b8a04b1d14ab170f43e31c220) Removed forget/save actions ### 📊 Changes **8 files changed** (+28 additions, -298 deletions) <details> <summary>View changed files</summary> 📝 `modules/imap/handler_modules.php` (+10 -114) 📝 `modules/imap/output_modules.php` (+0 -4) 📝 `modules/imap/setup.php` (+0 -4) 📝 `modules/imap/site.js` (+3 -49) 📝 `modules/imap_folders/modules.php` (+4 -4) 📝 `modules/smtp/modules.php` (+8 -70) 📝 `modules/smtp/setup.php` (+0 -4) 📝 `modules/smtp/site.js` (+3 -49) </details> ### 📄 Description This PR removes server forget/save buttons in favor of edit button. The context is that many fields are being added on server page (lately sieve_tls) and others may come. The forget/save cannot handle these in the future. Edit button instead allows users to edit all together SMTP and IMAP + Sieve with all the fields. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>