mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 21:15:56 +03:00
[PR #1266] [MERGED] Implement browser history API based navigation, preventing page reloads between routings #1392
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#1392
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/cypht-org/cypht/pull/1266
Author: @mercihabam
Created: 10/2/2024
Status: ✅ Merged
Merged: 10/18/2024
Merged by: @mercihabam
Base:
master← Head:prevent-page-reloads📝 Commits (10+)
b21b1c3Implement browser history API based navigation, preventing browser reloads between routings6ae9ba4A couple of fixes and refinements to the navigation module ensuring that data is consistantly displayed across routings2ea908bApply servers and settings page handlersaa538ebApply handlers on page load as well4d4bc0aUpdate the sidebar item's active state when navigating6eb67a3Fix displaying the message content with the correct route paramsae11804Move entire imap_folder_page_setup the the message list route handleref98763Fix refresh links4a9e66bFix sorting and filtering of messages72882c6imap unread handler: allow fetching the messages from the connected servers instead of only provided request server parameters📊 Changes
54 files changed (+2614 additions, -1537 deletions)
View changed files
📝
.gitignore(+1 -0)➕
modules/advanced_search/js_modules/route_handlers.js(+30 -0)📝
modules/advanced_search/site.js(+0 -34)📝
modules/calendar/hm-calendar.php(+1 -1)➕
modules/calendar/js_modules/route_handlers.js(+15 -0)📝
modules/calendar/site.js(+0 -17)➕
modules/contacts/js_modules/route_handlers.js(+33 -0)📝
modules/contacts/site.js(+2 -42)📝
modules/core/js_modules/Hm_MessagesStore.js(+60 -11)➕
modules/core/js_modules/route_handlers.js(+58 -0)➕
modules/core/navigation/navigation.js(+92 -0)➕
modules/core/navigation/routes.js(+89 -0)➕
modules/core/navigation/utils.js(+33 -0)📝
modules/core/output_modules.php(+24 -8)📝
modules/core/site.js(+65 -79)📝
modules/desktop_notifications/site.js(+1 -1)📝
modules/feeds/site.js(+11 -14)📝
modules/github/site.js(+17 -17)➕
modules/hello_world/js_modules/route_handlers.js(+8 -0)📝
modules/hello_world/site.js(+2 -12)...and 34 more files
📄 Description
https://github.com/cypht-org/cypht/issues/1144
Checklist:
When clicking on a message link while contents are still being fetched in the background, the requests should be aborted so the navigation is performed faster(Aborting the requests on the client doesn't help because, once the requests are sent, the server processes them synchronously, blocking other eventual requests. A solution could be processing the requests server-side asynchronously.)🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.