[PR #1230] [MERGED] fix multibyte handling in imap literals and address splitting, improve unit tests #1355

New issue

Closed

opened 2026-02-25 21:38:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:38:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1230
Author: @kroky
Created: 9/9/2024
Status: ✅ Merged
Merged: 9/9/2024
Merged by: @kroky

Base: master ← Head: bugfix/multibyte-imap

📝 Commits (2)

d5608ad fix imap::read_literal to work on 7-bit bytes rather than multibyte strings, fix imap unit tests and add tests for recent bugs: accidentally reading next lines of literals and not splitting addresses correctly
78486a6 add note about imap read_literal method

📊 Changes

5 files changed (+88 additions, -151 deletions)

View changed files

📝 modules/core/message_functions.php (+6 -5)
📝 modules/imap/hm-imap-base.php (+20 -14)
📝 tests/phpunit/imap_commands.php (+9 -3)
📝 tests/phpunit/modules/core/message_functions.php (+10 -0)
📝 tests/phpunit/modules/imap/hm_imap.php (+43 -129)

📄 Description

fix imap::read_literal to work on 7-bit bytes rather than multibyte strings, fix imap unit tests and add tests for recent bugs: accidentally reading next lines of literals and not splitting addresses correctly

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1230 **Author:** [@kroky](https://github.com/kroky) **Created:** 9/9/2024 **Status:** ✅ Merged **Merged:** 9/9/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `bugfix/multibyte-imap` --- ### 📝 Commits (2) - [`d5608ad`](https://github.com/cypht-org/cypht/commit/d5608ad4a1ec625d269ea245818aa7eb1435fc91) fix imap::read_literal to work on 7-bit bytes rather than multibyte strings, fix imap unit tests and add tests for recent bugs: accidentally reading next lines of literals and not splitting addresses correctly - [`78486a6`](https://github.com/cypht-org/cypht/commit/78486a6ce503eeed3237cd45d7f9eb802a4e180a) add note about imap read_literal method ### 📊 Changes **5 files changed** (+88 additions, -151 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/message_functions.php` (+6 -5) 📝 `modules/imap/hm-imap-base.php` (+20 -14) 📝 `tests/phpunit/imap_commands.php` (+9 -3) 📝 `tests/phpunit/modules/core/message_functions.php` (+10 -0) 📝 `tests/phpunit/modules/imap/hm_imap.php` (+43 -129) </details> ### 📄 Description fix imap::read_literal to work on 7-bit bytes rather than multibyte strings, fix imap unit tests and add tests for recent bugs: accidentally reading next lines of literals and not splitting addresses correctly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>