[PR #1125] [MERGED] Correct pagination while displaying contacts #1287

New issue

Closed

opened 2026-02-25 21:37:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:37:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1125
Author: @Shadow243
Created: 7/19/2024
Status: ✅ Merged
Merged: 10/22/2024
Merged by: @kroky

Base: master ← Head: correct-contact-group

📝 Commits (1)

4b77913 Correct pagination while displaying contacts

📊 Changes

2 files changed (+95 additions, -47 deletions)

View changed files

📝 modules/contacts/hm-contacts.php (+54 -2)
📝 modules/contacts/modules.php (+41 -45)

📄 Description

Paging affects groups.

Ex: if in trusted Contacts there are 100 contacts and in Collected Contacts we have 2 contacts, the pagination will ensure that the 2 contacts in Collected are not displayed.

In this PR we group first then we paginate what is already grouped

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1125 **Author:** [@Shadow243](https://github.com/Shadow243) **Created:** 7/19/2024 **Status:** ✅ Merged **Merged:** 10/22/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `correct-contact-group` --- ### 📝 Commits (1) - [`4b77913`](https://github.com/cypht-org/cypht/commit/4b77913f984ba26fc62f0a81dc5a9e4e42b57c87) Correct pagination while displaying contacts ### 📊 Changes **2 files changed** (+95 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `modules/contacts/hm-contacts.php` (+54 -2) 📝 `modules/contacts/modules.php` (+41 -45) </details> ### 📄 Description Paging affects groups. Ex: if in trusted Contacts there are 100 contacts and in Collected Contacts we have 2 contacts, the pagination will ensure that the 2 contacts in Collected are not displayed. In this PR we group first then we paginate what is already grouped --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>