[PR #1121] [MERGED] [FIX] Setting cookie SameSite to Lax when session type is set to DB #1282

Closed
opened 2026-02-25 21:37:47 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1121
Author: @Yannick243
Created: 7/16/2024
Status: Merged
Merged: 7/22/2024
Merged by: @kroky

Base: masterHead: oauth-session-db-fix


📝 Commits (1)

  • 6af521a [FIX] Setting cookie SameSite to Lax when session type is set to DB

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 lib/session_base.php (+1 -0)
📝 lib/session_db.php (+1 -1)

📄 Description

This PR follows up on https://github.com/cypht-org/cypht/pull/1021; it sets the cookie attribute SameSite to Lax when the session type is set to DB, fixing the OAUTH2 authorization callback issue where the user was logged out after performing the authorization flow.

Related issue: https://github.com/cypht-org/cypht/issues/1112


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1121 **Author:** [@Yannick243](https://github.com/Yannick243) **Created:** 7/16/2024 **Status:** ✅ Merged **Merged:** 7/22/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `oauth-session-db-fix` --- ### 📝 Commits (1) - [`6af521a`](https://github.com/cypht-org/cypht/commit/6af521aa491ffabdbb3af530d8f711082a96c46e) [FIX] Setting cookie SameSite to Lax when session type is set to DB ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/session_base.php` (+1 -0) 📝 `lib/session_db.php` (+1 -1) </details> ### 📄 Description This PR follows up on [https://github.com/cypht-org/cypht/pull/1021](https://github.com/cypht-org/cypht/pull/1021); it sets the cookie attribute SameSite to `Lax` when the session type is set to DB, fixing the OAUTH2 authorization callback issue where the user was logged out after performing the authorization flow. **Related issue:** [https://github.com/cypht-org/cypht/issues/1112](https://github.com/cypht-org/cypht/issues/1112) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:37:47 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#1282
No description provided.