[PR #1101] [CLOSED] Refact #1099 to make tests work #1269

Closed
opened 2026-02-25 21:37:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1101
Author: @Shadow243
Created: 6/21/2024
Status: Closed

Base: masterHead: correct-tests


📝 Commits (1)

📊 Changes

2 files changed (+14 additions, -9 deletions)

View changed files

📝 lib/config.php (+4 -1)
📝 modules/imap/handler_modules.php (+10 -8)

📄 Description

This change https://github.com/cypht-org/cypht/pull/1099/files#diff-b7fdf5637005ea55ecbcc642d9660fa0fe278967cd7ce7ac7dbd9bfa7c4e0ed8R149 affected the tests, upon rechecking I thought that a refactoring was necessary for the tests to pass without affecting the correction in the PR: https://github.com/cypht-org/cypht/pull/1099


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1101 **Author:** [@Shadow243](https://github.com/Shadow243) **Created:** 6/21/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `correct-tests` --- ### 📝 Commits (1) - [`3165cda`](https://github.com/cypht-org/cypht/commit/3165cda4923636c6df7c5bbbffc2d186f23258d1) Refact https://github.com/cypht-org/cypht/pull/1099 to make tests working ### 📊 Changes **2 files changed** (+14 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `lib/config.php` (+4 -1) 📝 `modules/imap/handler_modules.php` (+10 -8) </details> ### 📄 Description This change [https://github.com/cypht-org/cypht/pull/1099/files#diff-b7fdf5637005ea55ecbcc642d9660fa0fe278967cd7ce7ac7dbd9bfa7c4e0ed8R149](https://github.com/cypht-org/cypht/pull/1099/files#diff-b7fdf5637005ea55ecbcc642d9660fa0fe278967cd7ce7ac7dbd9bfa7c4e0ed8R149) affected the tests, upon rechecking I thought that a refactoring was necessary for the tests to pass without affecting the correction in the PR: https://github.com/cypht-org/cypht/pull/1099 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:37:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#1269
No description provided.