mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 13:05:53 +03:00
[GH-ISSUE #144] POP3 mail parser isn't same as IMAP mail parser, and POP3 mail parser's implementation is incompleted #119
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#119
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @hiroshitoda on GitHub (Oct 30, 2016).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/144
Originally assigned to: @jasonmunro on GitHub.
I think that POP3 mail data structure is same as IMAP's one.
But in Cypht, POP3 mail parser isn't same as IMAP's one, and POP3 mail parser's implementation is incompleted.
Because of this, POP3 mail parser cannot parse some mail data which is parsable with IMAP mail parser.
@hiroshitoda commented on GitHub (Oct 30, 2016):
So I make pull request #147 for fix POP3 parser in makeshift.
@jasonmunro commented on GitHub (Oct 31, 2016):
Thank you for working on this! You are correct, POP3 and IMAP use different code paths for E-mail structure. The reason for this is because IMAP provides the BODYSTRUCTURE command that we can use to parse a message without having to download the entire thing. So basically we offload message parsing to the IMAP server itself. The POP3 protocol does not have this functionality, so we have no choice but to parse it ourselves, and as you noticed our implementation is incomplete.
I will test and merge your pull request to improve POP3 parsing this week. Thanks again!
@jasonmunro commented on GitHub (Nov 1, 2016):
Pull request is merged. Thanks again!