[PR #964] [MERGED] use WEB_ROOT consistently in output_modules.php #1180

Closed
opened 2026-02-25 21:37:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/964
Author: @TheDigitalOrchard
Created: 4/18/2024
Status: Merged
Merged: 4/20/2024
Merged by: @josaphatim

Base: masterHead: WEBROOT-consistency-2


📝 Commits (1)

  • 5f03778 take two - inject WEB_ROOT consistently in output_modules.php

📊 Changes

1 file changed (+39 additions, -39 deletions)

View changed files

📝 modules/core/output_modules.php (+39 -39)

📄 Description

Pullrequest

Take two!

Use WEB_ROOT consistently throughout core/output_modules.php. In some setups, this allows vendor and third_party assets to load correctly. Should not have any compatibility issues.

Please advise if moving from a relative to a root-relative path is less than ideal.

Issues

  • None

Checklist

  • None

How2Test

  • None

Todo

  • None

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/964 **Author:** [@TheDigitalOrchard](https://github.com/TheDigitalOrchard) **Created:** 4/18/2024 **Status:** ✅ Merged **Merged:** 4/20/2024 **Merged by:** [@josaphatim](https://github.com/josaphatim) **Base:** `master` ← **Head:** `WEBROOT-consistency-2` --- ### 📝 Commits (1) - [`5f03778`](https://github.com/cypht-org/cypht/commit/5f03778d197d312069c6a52e01255d35b45b1595) take two - inject WEB_ROOT consistently in output_modules.php ### 📊 Changes **1 file changed** (+39 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/output_modules.php` (+39 -39) </details> ### 📄 Description ## Pullrequest Take two! Use WEB_ROOT consistently throughout `core/output_modules.php`. In some setups, this allows `vendor` and `third_party` assets to load correctly. Should not have any compatibility issues. Please advise if moving from a relative to a root-relative path is less than ideal. ### Issues <!-- Which Issues does this fix, which are related? - fixes #XXX - relates #XXX --> - [X] None ### Checklist <!-- Anything important to be thought of when deploying? - [ ] Config Update - [ ] Breaking/critical change --> - [X] None ### How2Test <!-- Give a detailed description how to test your PR and confirm it is working as expected. --> <!-- Maintainers will check the Tests - [ ] Test1 - [ ] Test2 --> - [X] None ### Todo <!-- In case some parts are still missing, list them here. - [ ] Changelog --> - [X] None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:37:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#1180
No description provided.