[PR #895] [MERGED] Added bootstrap files to optimized css/js files #1124

New issue

Closed

opened 2026-02-25 21:37:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:37:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/895
Author: @josaphatim
Created: 2/12/2024
Status: ✅ Merged
Merged: 2/13/2024
Merged by: @kroky

Base: master ← Head: fixed-duplicated-call-for-bootstrap-files

📝 Commits (1)

a562026 Added bootstrap files to optimized css/js files

📊 Changes

6 files changed (+43 additions, -24 deletions)

View changed files

📝 modules/2fa/modules.php (+2 -2)
📝 modules/core/functions.php (+3 -3)
📝 modules/core/output_modules.php (+8 -10)
📝 modules/core/site.css (+1 -4)
📝 scripts/config_gen.php (+26 -2)
📝 tests/phpunit/modules/core/modules.php (+3 -3)

📄 Description

/site folder was missing bootstrap. I also fixed duplicated css files I mean bootstrap.min.css and bootstrap-icons.css were present twice in the head tag. Now accessing to /site will load all needed css/js files. This issue was impacting embedded tiki as bootstrap/bootstrap icons weren't loaded.

I also allowed css header and js files on login page to make bootstrap and js files available there. With this MR now clicking on close button in an alert message on login page will close it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/895 **Author:** [@josaphatim](https://github.com/josaphatim) **Created:** 2/12/2024 **Status:** ✅ Merged **Merged:** 2/13/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `fixed-duplicated-call-for-bootstrap-files` --- ### 📝 Commits (1) - [`a562026`](https://github.com/cypht-org/cypht/commit/a562026bd392f74f74c90966c6e6e15c178b5136) Added bootstrap files to optimized css/js files ### 📊 Changes **6 files changed** (+43 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `modules/2fa/modules.php` (+2 -2) 📝 `modules/core/functions.php` (+3 -3) 📝 `modules/core/output_modules.php` (+8 -10) 📝 `modules/core/site.css` (+1 -4) 📝 `scripts/config_gen.php` (+26 -2) 📝 `tests/phpunit/modules/core/modules.php` (+3 -3) </details> ### 📄 Description /site folder was missing bootstrap. I also fixed duplicated css files I mean bootstrap.min.css and bootstrap-icons.css were present twice in the head tag. Now accessing to /site will load all needed css/js files. This issue was impacting embedded tiki as bootstrap/bootstrap icons weren't loaded. I also allowed css header and js files on login page to make bootstrap and js files available there. With this MR now clicking on close button in an alert message on login page will close it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>