[PR #881] [MERGED] Add SortableJs to $js_lib in config_gen to combine_includes #1113

New issue

Closed

opened 2026-02-25 21:37:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:37:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/881
Author: @Shadow243
Created: 2/5/2024
Status: ✅ Merged
Merged: 2/6/2024
Merged by: @kroky

Base: master ← Head: add-sortablejs-in-prod-mode

📝 Commits (1)

361a846 Add SortableJs to in config_gen to combine_includes

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 scripts/config_gen.php (+1 -0)

📄 Description

Add

$js_lib .= file_get_contents("third_party/sortable.min.js");

to combine_includes to prevent prod error:

Uncaught ReferenceError: Sortable is not defined ......

From issue: https://github.com/cypht-org/cypht/issues/878

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/881 **Author:** [@Shadow243](https://github.com/Shadow243) **Created:** 2/5/2024 **Status:** ✅ Merged **Merged:** 2/6/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `add-sortablejs-in-prod-mode` --- ### 📝 Commits (1) - [`361a846`](https://github.com/cypht-org/cypht/commit/361a846103bc50481bc6b34857bac4cc2c8268ca) Add SortableJs to in config_gen to combine_includes ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `scripts/config_gen.php` (+1 -0) </details> ### 📄 Description Add ``` $js_lib .= file_get_contents("third_party/sortable.min.js"); ``` to combine_includes to prevent prod error: ``` Uncaught ReferenceError: Sortable is not defined ...... ```` From issue: [https://github.com/cypht-org/cypht/issues/878](https://github.com/cypht-org/cypht/issues/878) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>