[PR #872] [MERGED] Issue with module name during development on Windows #1107

Closed
opened 2026-02-25 21:37:15 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/872
Author: @ElvisAns
Created: 1/23/2024
Status: Merged
Merged: 2/20/2024
Merged by: @kroky

Base: masterHead: fix-css-and-js-path-in-debug-mode


📝 Commits (2)

  • 2ab9060 replace "" in module name as well
  • df225ad Use directory seperator constant

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 modules/core/output_modules.php (+5 -5)

📄 Description

Pullrequest

Issues

  • During development (APP_DEBUG enabled) cypht dont load correctly css and js files unless i go to /site
    image
    image

Checklist

  • None

How2Test

  • I tested this on a windows computer, so i believe it's a platform dependent issue. To test, pull the branch an ensure the site load correctly without going to /site
    image

Todo

  • None

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/872 **Author:** [@ElvisAns](https://github.com/ElvisAns) **Created:** 1/23/2024 **Status:** ✅ Merged **Merged:** 2/20/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `fix-css-and-js-path-in-debug-mode` --- ### 📝 Commits (2) - [`2ab9060`](https://github.com/cypht-org/cypht/commit/2ab9060bddf0a4d63b7bd07299856fa930275c29) replace "\" in module name as well - [`df225ad`](https://github.com/cypht-org/cypht/commit/df225ada8f312ad5e609bbac679fdd2713c7dfc9) Use directory seperator constant ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/output_modules.php` (+5 -5) </details> ### 📄 Description ## Pullrequest <!-- Describe the Pullrequest. --> ### Issues <!-- Which Issues does this fix, which are related? - fixes #XXX - relates #XXX --> - [X] During development (APP_DEBUG enabled) cypht dont load correctly css and js files unless i go to /site ![image](https://github.com/cypht-org/cypht/assets/35831811/28fe3a63-113a-41bd-93e0-5d37205613f6) ![image](https://github.com/cypht-org/cypht/assets/35831811/b2bad873-bd2f-40c3-a82d-72d69ee42bd8) ### Checklist <!-- Anything important to be thought of when deploying? - [ ] Config Update - [ ] Breaking/critical change --> - [X] None ### How2Test <!-- Give a detailed description how to test your PR and confirm it is working as expected. --> <!-- Maintainers will check the Tests - [ ] Test1 - [ ] Test2 --> - [X] I tested this on a windows computer, so i believe it's a platform dependent issue. To test, pull the branch an ensure the site load correctly without going to /site ![image](https://github.com/cypht-org/cypht/assets/35831811/77fc4e2d-059b-485f-897e-38a46574f777) ### Todo <!-- In case some parts are still missing, list them here. - [ ] Changelog --> - [X] None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:37:15 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#1107
No description provided.