[PR #864] [MERGED] [FIX] allow drag and drop of recipients with accents in the name #1102

Closed
opened 2026-02-25 21:37:14 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/864
Author: @mercihabam
Created: 1/12/2024
Status: Merged
Merged: 2/19/2024
Merged by: @kroky

Base: masterHead: reordering-of-recipients


📝 Commits (2)

  • 4f6e10a [FIX] allow drag and drop of recipients with accents in the name
  • cd7c82f replace FILTER_SANITIZE_FULL_SPECIAL_CHARS with FILTER_DEFAULT to avoid encoding of inputs

📊 Changes

33 files changed (+299 additions, -294 deletions)

View changed files

📝 modules/2fa/setup.php (+1 -1)
📝 modules/account/setup.php (+3 -3)
📝 modules/advanced_search/setup.php (+7 -7)
📝 modules/api_login/setup.php (+3 -3)
📝 modules/calendar/setup.php (+9 -9)
📝 modules/carddav_contacts/setup.php (+7 -7)
📝 modules/contacts/modules.php (+11 -6)
📝 modules/contacts/setup.php (+12 -12)
📝 modules/core/setup.php (+57 -57)
📝 modules/dynamic_login/setup.php (+1 -1)
📝 modules/feeds/setup.php (+11 -11)
📝 modules/github/setup.php (+9 -9)
📝 modules/hello_world/setup.php (+1 -1)
📝 modules/highlights/setup.php (+7 -7)
📝 modules/imap/setup.php (+42 -42)
📝 modules/imap_folders/setup.php (+5 -5)
📝 modules/inline_message/setup.php (+1 -1)
📝 modules/keyboard_shortcuts/setup.php (+1 -1)
📝 modules/ldap_contacts/setup.php (+25 -25)
📝 modules/nasa/setup.php (+2 -2)

...and 13 more files

📄 Description

Pull Request

This pull request addresses the issue encountered while trying to reorder recipients between the fields to, cc, and bcc, which was not functioning. Additionally, it resolves the problem where a bubble was not being formed for a contact with an accent in the name.

Issues

Checklist

  • None

How2Test

  • Create some contacts in your interface (with or without accents in the name)
  • Navigate to compose
  • Type the contact in the field to, cc, or 'bcc. Once the contact is found and inserted in the field
  • You can drag-and-drop it to move to another field.

Todo

  • None

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/864 **Author:** [@mercihabam](https://github.com/mercihabam) **Created:** 1/12/2024 **Status:** ✅ Merged **Merged:** 2/19/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `reordering-of-recipients` --- ### 📝 Commits (2) - [`4f6e10a`](https://github.com/cypht-org/cypht/commit/4f6e10a538a03e6823b328894bf280ce8185baa6) [FIX] allow drag and drop of recipients with accents in the name - [`cd7c82f`](https://github.com/cypht-org/cypht/commit/cd7c82f11f7fbbd4d7c32ff2c63cf9e86072943b) replace FILTER_SANITIZE_FULL_SPECIAL_CHARS with FILTER_DEFAULT to avoid encoding of inputs ### 📊 Changes **33 files changed** (+299 additions, -294 deletions) <details> <summary>View changed files</summary> 📝 `modules/2fa/setup.php` (+1 -1) 📝 `modules/account/setup.php` (+3 -3) 📝 `modules/advanced_search/setup.php` (+7 -7) 📝 `modules/api_login/setup.php` (+3 -3) 📝 `modules/calendar/setup.php` (+9 -9) 📝 `modules/carddav_contacts/setup.php` (+7 -7) 📝 `modules/contacts/modules.php` (+11 -6) 📝 `modules/contacts/setup.php` (+12 -12) 📝 `modules/core/setup.php` (+57 -57) 📝 `modules/dynamic_login/setup.php` (+1 -1) 📝 `modules/feeds/setup.php` (+11 -11) 📝 `modules/github/setup.php` (+9 -9) 📝 `modules/hello_world/setup.php` (+1 -1) 📝 `modules/highlights/setup.php` (+7 -7) 📝 `modules/imap/setup.php` (+42 -42) 📝 `modules/imap_folders/setup.php` (+5 -5) 📝 `modules/inline_message/setup.php` (+1 -1) 📝 `modules/keyboard_shortcuts/setup.php` (+1 -1) 📝 `modules/ldap_contacts/setup.php` (+25 -25) 📝 `modules/nasa/setup.php` (+2 -2) _...and 13 more files_ </details> ### 📄 Description ## Pull Request This pull request addresses the issue encountered while trying to reorder recipients between the fields `to`, `cc`, and `bcc`, which was not functioning. Additionally, it resolves the problem where a bubble was not being formed for a contact with an accent in the name. ### Issues <!-- Which Issues does this fix, which are related? - fixes #XXX - relates #XXX --> - [X] https://avan.tech/item98845 ### Checklist <!-- Anything important to be thought of when deploying? - [ ] Config Update - [ ] Breaking/critical change --> - [X] None ### How2Test <!-- Give a detailed description how to test your PR and confirm it is working as expected. --> <!-- Maintainers will check the Tests --> - [ ] Create some contacts in your interface (with or without accents in the name) - [ ] Navigate to `compose` - [ ] Type the contact in the field `to`, `cc, or 'bcc`. Once the contact is found and inserted in the field - [ ] You can drag-and-drop it to move to another field. ### Todo <!-- In case some parts are still missing, list them here. - [ ] Changelog --> - [x] None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:37:14 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#1102
No description provided.