[PR #839] [MERGED] Fix Warn about potential missing attachment when sending an email #1084

New issue

Closed

opened 2026-02-25 21:37:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:37:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/839
Author: @Shadow243
Created: 12/11/2023
Status: ✅ Merged
Merged: 2/5/2024
Merged by: @kroky

Base: master ← Head: attachment-reminder

📝 Commits (2)

0ea542e Fix Warn about potential missing attachment when sending an email
da5629a resolve #868 conflits

📊 Changes

21 files changed (+176 additions, -19 deletions)

View changed files

📝 language/az.php (+2 -0)
📝 language/de.php (+2 -0)
📝 language/en.php (+2 -0)
📝 language/es.php (+2 -0)
📝 language/et.php (+2 -0)
📝 language/fa.php (+2 -0)
📝 language/fr.php (+2 -0)
📝 language/hu.php (+2 -0)
📝 language/id.php (+2 -0)
📝 language/it.php (+2 -0)
📝 language/ja.php (+2 -0)
📝 language/nl.php (+2 -0)
📝 language/pt-BR.php (+2 -0)
📝 language/ro.php (+2 -0)
📝 language/ru.php (+2 -0)
📝 language/zh-Hans.php (+2 -0)
📝 lib/module.php (+23 -0)
📝 modules/core/output_modules.php (+9 -0)
📝 modules/smtp/modules.php (+35 -3)
📝 modules/smtp/setup.php (+6 -1)

...and 1 more files

📄 Description

Warn about potential missing attachment when sending an email #684

Description

Introduce a feature to warn users about potential missing attachments when composing and sending an email. This includes a configuration setting to toggle the feature, JavaScript implementation for keyword checking, modal notification, and an option to force send.

Implementation Steps

Configuration Setting
- Introduce enable_attachment_reminder configuration value.
JavaScript Implementation
- Implement keyword checking in the email body.
- Store keywords in the translated_keywords variable.
Modal Notification
- Display a modal notification when keywords suggest a missing attachment.
- Include information about the potential missing attachment.
Force Send Option
- Provide a "Send Anyway" button within the modal.
Testing
- Test the feature in various scenarios.
- Ensure the modal appears only when necessary.

Additional Information

Issue: #684

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/839 **Author:** [@Shadow243](https://github.com/Shadow243) **Created:** 12/11/2023 **Status:** ✅ Merged **Merged:** 2/5/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `attachment-reminder` --- ### 📝 Commits (2) - [`0ea542e`](https://github.com/cypht-org/cypht/commit/0ea542e5d1e96c3bdf892664e51c35acdedb974c) Fix Warn about potential missing attachment when sending an email - [`da5629a`](https://github.com/cypht-org/cypht/commit/da5629afd945e3ea909d63b823c1d463ed0f1d34) resolve #868 conflits ### 📊 Changes **21 files changed** (+176 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `language/az.php` (+2 -0) 📝 `language/de.php` (+2 -0) 📝 `language/en.php` (+2 -0) 📝 `language/es.php` (+2 -0) 📝 `language/et.php` (+2 -0) 📝 `language/fa.php` (+2 -0) 📝 `language/fr.php` (+2 -0) 📝 `language/hu.php` (+2 -0) 📝 `language/id.php` (+2 -0) 📝 `language/it.php` (+2 -0) 📝 `language/ja.php` (+2 -0) 📝 `language/nl.php` (+2 -0) 📝 `language/pt-BR.php` (+2 -0) 📝 `language/ro.php` (+2 -0) 📝 `language/ru.php` (+2 -0) 📝 `language/zh-Hans.php` (+2 -0) 📝 `lib/module.php` (+23 -0) 📝 `modules/core/output_modules.php` (+9 -0) 📝 `modules/smtp/modules.php` (+35 -3) 📝 `modules/smtp/setup.php` (+6 -1) _...and 1 more files_ </details> ### 📄 Description ## Warn about potential missing attachment when sending an email #684 ### Description Introduce a feature to warn users about potential missing attachments when composing and sending an email. This includes a configuration setting to toggle the feature, JavaScript implementation for keyword checking, modal notification, and an option to force send. ### Implementation Steps 1. **Configuration Setting** - [ ] Introduce `enable_attachment_reminder` configuration value. 2. **JavaScript Implementation** - [ ] Implement keyword checking in the email body. - [ ] Store keywords in the `translated_keywords` variable. 3. **Modal Notification** - [ ] Display a modal notification when keywords suggest a missing attachment. - [ ] Include information about the potential missing attachment. 4. **Force Send Option** - [ ] Provide a "Send Anyway" button within the modal. 5. **Testing** - [ ] Test the feature in various scenarios. - [ ] Ensure the modal appears only when necessary. ### Additional Information - **Issue:** #684 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>