[PR #822] [MERGED] Fix Spaces in passwords are not handled correctly when adding servers #1071

New issue

Closed

opened 2026-02-25 21:37:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:37:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/822
Author: @Shadow243
Created: 11/4/2023
Status: ✅ Merged
Merged: 3/5/2024
Merged by: @kroky

Base: master ← Head: smtp-imap-space-in-password

📝 Commits (1)

d07bb2e Fix Spaces in passwords are not handled correctly when adding servers issue

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 modules/core/site.js (+1 -1)

📄 Description

Issue Description

I encountered an issue where spaces in passwords were being encoded as + when submitting a POST request with the Content-Type application/x-www-form-urlencoded. This behavior was causing problems, as passwords with spaces were not processed correctly on the server.

Proposed Correction

To address this issue, I added URL decoding (urldecode()) to the server-side code to properly decode data received from the POST request. This ensures that spaces in passwords are correctly handled and not transformed into + symbols. As a result, passwords containing spaces are now processed as expected.

Steps to Reproduce

Submit a POST request with Content-Type application/x-www-form-urlencoded.
Include a password with spaces in the request data.
Observe that the spaces are correctly decoded on the server side.

This change should resolve the issue as described in Issue #821 and ensure that passwords with spaces are handled correctly in POST requests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/822 **Author:** [@Shadow243](https://github.com/Shadow243) **Created:** 11/4/2023 **Status:** ✅ Merged **Merged:** 3/5/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `smtp-imap-space-in-password` --- ### 📝 Commits (1) - [`d07bb2e`](https://github.com/cypht-org/cypht/commit/d07bb2e61a6d36cf85f8a543f725d2f00b0ec25d) Fix Spaces in passwords are not handled correctly when adding servers issue ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/site.js` (+1 -1) </details> ### 📄 Description ### Issue Description I encountered an issue where spaces in passwords were being encoded as `+` when submitting a POST request with the Content-Type `application/x-www-form-urlencoded`. This behavior was causing problems, as passwords with spaces were not processed correctly on the server. ### Proposed Correction To address this issue, I added URL decoding (`urldecode()`) to the server-side code to properly decode data received from the POST request. This ensures that spaces in passwords are correctly handled and not transformed into `+` symbols. As a result, passwords containing spaces are now processed as expected. ### Steps to Reproduce 1. Submit a POST request with Content-Type `application/x-www-form-urlencoded`. 2. Include a password with spaces in the request data. 3. Observe that the spaces are correctly decoded on the server side. This change should resolve the issue as described in [Issue #821](https://github.com/cypht-org/cypht/issues/821) and ensure that passwords with spaces are handled correctly in POST requests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>