[PR #751] [MERGED] No more losing search term when changing page #1028

New issue

Closed

opened 2026-02-25 21:36:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/751
Author: @mmarcwabo
Created: 8/25/2023
Status: ✅ Merged
Merged: 8/29/2023
Merged by: @kroky

Base: master ← Head: fix_search_term_is_lost_when_changing_pages

📝 Commits (2)

f32f25c No more losing search term when changing page
277c7cf Fix variable name: keyword instead of sort

📊 Changes

3 files changed (+14 additions, -7 deletions)

View changed files

📝 modules/core/message_list_functions.php (+12 -6)
📝 modules/imap/output_modules.php (+1 -1)
📝 tests/phpunit/modules/core/message_list_functions.php (+1 -0)

📄 Description

Pullrequest

Make it possible to no more lose search term when changing page

Issues

None

Checklist

None

How2Test

Run unit tests (test_build_page_links() one more assertion)
Make a search within an account that has pagination and observe the behaviour

Todo

None

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/751 **Author:** [@mmarcwabo](https://github.com/mmarcwabo) **Created:** 8/25/2023 **Status:** ✅ Merged **Merged:** 8/29/2023 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `fix_search_term_is_lost_when_changing_pages` --- ### 📝 Commits (2) - [`f32f25c`](https://github.com/cypht-org/cypht/commit/f32f25c3d48d71c6b7499770b634ec3d1c0ac982) No more losing search term when changing page - [`277c7cf`](https://github.com/cypht-org/cypht/commit/277c7cfeb91f9210e4b43723a72c3eaaf563af0e) Fix variable name: keyword instead of sort ### 📊 Changes **3 files changed** (+14 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/message_list_functions.php` (+12 -6) 📝 `modules/imap/output_modules.php` (+1 -1) 📝 `tests/phpunit/modules/core/message_list_functions.php` (+1 -0) </details> ### 📄 Description ## Pullrequest Make it possible to no more lose search term when changing page ### Issues - [x] None ### Checklist - [X] None ### How2Test - [x] Run unit tests (test_build_page_links() one more assertion) - [x] Make a search within an account that has pagination and observe the behaviour ### Todo - [X] None ![2023-01-20_214949](https://github.com/cypht-org/cypht/assets/1004261/93abd59f-2ed0-410c-beba-67ce06a0843f) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>