[PR #12] [MERGED] Snapshot name fix #98

New issue

Closed

opened 2026-02-26 17:44:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 17:44:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Corsinvest/cv4pve-autosnap/pull/12
Author: @MichiFry
Created: 6/27/2019
Status: ✅ Merged
Merged: 6/28/2019
Merged by: @franklupo

Base: master ← Head: zfs

📝 Commits (1)

5d5ef51 Fixed the read of existing snapshots in:

📊 Changes

1 file changed (+9 additions, -12 deletions)

View changed files

📝 eve4pve-autosnap (+9 -12)

📄 Description

Fixed the read of existing snapshot names in:

remove_old_snapshots
status

This fixes:
*) status output

Before on Ceph:
eve4pve-autosnap status
VM SNAPSHOTS LABEL
100 190620230005-daily- ::

After:
eve4pve-autosnap status
VM SNAPSHOTS LABEL
100 190627160350 daily

testet with: zfs, ceph, local

*) correct auto delete of snapshots on ZFS. (Before snapshots on some ZFS hosts were not deleted)

Output from ZFS on pve host 1:
pve1# qm listsnapshot 310
-> autodaily190623230006 2019-06-23 23:00:13 eve4pve-autosnap -> autodaily190624230004 2019-06-24 23:00:11 eve4pve-autosnap
`-> autodaily190625230017 2019-06-25 23:01:10 eve4pve-autosnap

Output from ZFS on pve host 2:
pve2# qm listsnapshot 1902
autodaily190627160118 no-parent eve4pve-autosnap
autodaily190627174021 autodaily190627173751 eve4pve-autosnap
autodaily190627173751 autodaily190627160118 eve4pve-autosnap

(Standard pve installations, both full updated)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Corsinvest/cv4pve-autosnap/pull/12 **Author:** [@MichiFry](https://github.com/MichiFry) **Created:** 6/27/2019 **Status:** ✅ Merged **Merged:** 6/28/2019 **Merged by:** [@franklupo](https://github.com/franklupo) **Base:** `master` ← **Head:** `zfs` --- ### 📝 Commits (1) - [`5d5ef51`](https://github.com/Corsinvest/cv4pve-autosnap/commit/5d5ef51d65d939a8b0f935ea71ba555774fe2cb5) Fixed the read of existing snapshots in: ### 📊 Changes **1 file changed** (+9 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `eve4pve-autosnap` (+9 -12) </details> ### 📄 Description Fixed the read of existing snapshot names in: - remove_old_snapshots - status This fixes: *) status output Before on Ceph: eve4pve-autosnap status VM SNAPSHOTS LABEL 100 190620230005-daily- :: After: eve4pve-autosnap status VM SNAPSHOTS LABEL 100 190627160350 daily testet with: zfs, ceph, local *) correct auto delete of snapshots on ZFS. (Before snapshots on some ZFS hosts were not deleted) Output from ZFS on pve host 1: pve1# qm listsnapshot 310 `-> autodaily190623230006 2019-06-23 23:00:13 eve4pve-autosnap `-> autodaily190624230004 2019-06-24 23:00:11 eve4pve-autosnap `-> autodaily190625230017 2019-06-25 23:01:10 eve4pve-autosnap Output from ZFS on pve host 2: pve2# qm listsnapshot 1902 autodaily190627160118 no-parent eve4pve-autosnap autodaily190627174021 autodaily190627173751 eve4pve-autosnap autodaily190627173751 autodaily190627160118 eve4pve-autosnap (Standard pve installations, both full updated) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>