mirror of
https://github.com/Corsinvest/cv4pve-autosnap.git
synced 2026-04-25 08:55:49 +03:00
[GH-ISSUE #84] Incomplete error handling (or lack of filtering) for "non-snapshottable" machines #79
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cv4pve-autosnap#79
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @meyergru on GitHub (Nov 29, 2023).
Original GitHub issue: https://github.com/Corsinvest/cv4pve-autosnap/issues/84
What happened?
I added a new VM, only to find that cv4pve snapshots caused consistent errors (Unhandled expections). The error output was indeed meaningless, it did neither contain the VMID which was the culprit nor the probable cause:
I was lucky to conclude it was the new machine which causes this. I often have similar intermittent failures where I cannot lay my hand on what the reason could be. The side-effect is that all machines after the culprit are not snapshotted any more.
The reason for this is that the VM in question has a passthrough disk attached, thus it cannot be snapshotted. The "snapshot" section of the PVE manager says: "The current guest configuration does not support taking new snapshots". I wonder if this can be seen through the API.
Expected behavior
At least, this (and similar) condition(s) should be detected and a warning should be given, skipping to the next machine. If possible, an implicit or explicit filtering condition like with "--only-running" should be applied to skip such VMs / LXCs if --vmid="all" is specified.
Relevant log output
Proxmox VE Version
8.1.3
Version (bug)
1.14.8
Version (working)
On what operating system are you experiencing the issue?
Linux
Pull Request
@franklupo commented on GitHub (Apr 17, 2024):
Fix in the next release.