[PR #50] [MERGED] Bump version to 9.1.2 and improve code quality #51

Closed
opened 2026-02-26 17:32:25 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Corsinvest/cv4pve-api-powershell/pull/50
Author: @franklupo
Created: 2/9/2026
Status: Merged
Merged: 2/9/2026
Merged by: @franklupo

Base: masterHead: fix-issue-49


📝 Commits (1)

  • 0a55252 Bump version to 9.1.2 and improve code quality

📊 Changes

2 files changed (+4 additions, -9 deletions)

View changed files

📝 Corsinvest.ProxmoxVE.Api/Corsinvest.ProxmoxVE.Api.psd1 (+2 -2)
📝 Corsinvest.ProxmoxVE.Api/Corsinvest.ProxmoxVE.Api.psm1 (+2 -7)

📄 Description

Summary

  • Update module version from 9.1.1 to 9.1.2
  • Fix null comparison to use Yoda condition ($null -ne instead of -ne $null)
  • Refactor IsNumeric function to use PowerShell type casting idiom

Test plan

  • Verify module version is updated to 9.1.2
  • Test null comparisons work correctly
  • Test IsNumeric function with various inputs

Fixes #49


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Corsinvest/cv4pve-api-powershell/pull/50 **Author:** [@franklupo](https://github.com/franklupo) **Created:** 2/9/2026 **Status:** ✅ Merged **Merged:** 2/9/2026 **Merged by:** [@franklupo](https://github.com/franklupo) **Base:** `master` ← **Head:** `fix-issue-49` --- ### 📝 Commits (1) - [`0a55252`](https://github.com/Corsinvest/cv4pve-api-powershell/commit/0a552523046443db73ef1f930d7bc2d0bbbf1d04) Bump version to 9.1.2 and improve code quality ### 📊 Changes **2 files changed** (+4 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Corsinvest.ProxmoxVE.Api/Corsinvest.ProxmoxVE.Api.psd1` (+2 -2) 📝 `Corsinvest.ProxmoxVE.Api/Corsinvest.ProxmoxVE.Api.psm1` (+2 -7) </details> ### 📄 Description ## Summary - Update module version from 9.1.1 to 9.1.2 - Fix null comparison to use Yoda condition (`$null -ne` instead of `-ne $null`) - Refactor `IsNumeric` function to use PowerShell type casting idiom ## Test plan - [ ] Verify module version is updated to 9.1.2 - [ ] Test null comparisons work correctly - [ ] Test IsNumeric function with various inputs Fixes #49 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 17:32:25 +03:00
Sign in to join this conversation.
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cv4pve-api-powershell#51
No description provided.