[PR #21] [MERGED] waitForTaskToFinish fix and change #32

New issue

Closed

opened 2026-02-26 17:32:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 17:32:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Corsinvest/cv4pve-api-php/pull/21
Author: @Oren-C
Created: 11/25/2022
Status: ✅ Merged
Merged: 11/25/2022
Merged by: @franklupo

Base: master ← Head: Oren-C-patch-1

📝 Commits (1)

ba768a9 waitForTaskToFinish fix and change

📊 Changes

1 file changed (+9 additions, -8 deletions)

View changed files

📝 src/PveClientBase.php (+9 -8)

📄 Description

Incorrect parentheses, time should be in milliseconds. (time() returns seconds https://www.php.net/manual/en/function.time.php)
Verify if task is running at start (not strictly necessary but will save a wait if function is called when task has finished).

Credit for milliseconds https://stackoverflow.com/questions/3656713/how-to-get-current-time-in-milliseconds-in-php

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Corsinvest/cv4pve-api-php/pull/21 **Author:** [@Oren-C](https://github.com/Oren-C) **Created:** 11/25/2022 **Status:** ✅ Merged **Merged:** 11/25/2022 **Merged by:** [@franklupo](https://github.com/franklupo) **Base:** `master` ← **Head:** `Oren-C-patch-1` --- ### 📝 Commits (1) - [`ba768a9`](https://github.com/Corsinvest/cv4pve-api-php/commit/ba768a9ab8f64a41e92ae4a3bc032b868aa2d323) waitForTaskToFinish fix and change ### 📊 Changes **1 file changed** (+9 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/PveClientBase.php` (+9 -8) </details> ### 📄 Description Incorrect parentheses, time should be in milliseconds. (time() returns seconds https://www.php.net/manual/en/function.time.php) Verify if task is running at start (not strictly necessary but will save a wait if function is called when task has finished). Credit for milliseconds https://stackoverflow.com/questions/3656713/how-to-get-current-time-in-milliseconds-in-php --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>