[PR #244] feat: add snapshot size field and refactor resource URL helpers #324

New issue

Closed

opened 2026-03-07 19:57:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 19:57:35 +03:00

Owner

Original Pull Request: https://github.com/Corsinvest/cv4pve-admin/pull/244

State: closed
Merged: Yes

Summary

Add Size field to GuestSnapshotInfo, populated from disk snapshot data
PveDataProvider.GetSnapshotsAsync fetches DiskSnapshotInfos and maps size per snapshot
VmTools MCP tool: add optional include_size parameter (slower, includes on-disk size in bytes)
Move GetPveUrl from PveAdminHelper to UrlHelper (centralize URL logic)
Add UrlHelper.Resources.GetUrl to generate app-side links per resource type
ClusterResourceEx: add LinkPve field (PVE web UI link) separate from Link (app link)
ResourcesEx: show LinkPve column, fix DescriptionAsLink null guard

Test plan

Snapshot list shows Size column when include_size=true via MCP
ResourcesEx grid shows both app link and PVE link columns
DescriptionAsLink works correctly when Link is empty

**Original Pull Request:** https://github.com/Corsinvest/cv4pve-admin/pull/244 **State:** closed **Merged:** Yes --- ## Summary - Add `Size` field to `GuestSnapshotInfo`, populated from disk snapshot data - `PveDataProvider.GetSnapshotsAsync` fetches `DiskSnapshotInfos` and maps size per snapshot - `VmTools` MCP tool: add optional `include_size` parameter (slower, includes on-disk size in bytes) - Move `GetPveUrl` from `PveAdminHelper` to `UrlHelper` (centralize URL logic) - Add `UrlHelper.Resources.GetUrl` to generate app-side links per resource type - `ClusterResourceEx`: add `LinkPve` field (PVE web UI link) separate from `Link` (app link) - `ResourcesEx`: show `LinkPve` column, fix `DescriptionAsLink` null guard ## Test plan - [ ] Snapshot list shows Size column when `include_size=true` via MCP - [ ] ResourcesEx grid shows both app link and PVE link columns - [ ] DescriptionAsLink works correctly when Link is empty