[PR #236] feat: DRS settings fix, SendMessage refactor, session/hub service moves, UI cleanup #316

New issue

Closed

opened 2026-03-07 19:57:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 19:57:33 +03:00

Owner

Original Pull Request: https://github.com/Corsinvest/cv4pve-admin/pull/236

State: closed
Merged: No

Summary

Fix NullReferenceException saving DRS settings: add SetAsync<TModule,TSetting> generic extension in SettingsServiceExtensions that resolves section/key via GetContextModule/GetKeyModule, avoiding dependency on RenderSettingsInfo (which is null for modules using NavBar Config instead of the settings dialog)
Refactor SendMessageDialog: moved out of SendMessage/ subfolder, removed SendMessageModel class, added SendMessageDialog.razor.cs code-behind
Move MessageSeverity from Session/ to Models/
Move ISessionHubService from Session/ to Services/; delete SessionHubService.cs (dead code)
AppToken support: AppTokenPermissionsGrid, WebApiCredentialSettings, System migrations (AddAppTokens)
EnumDropDown: add AllowFloatingLabel=false default
Fix HelpMenu feedback link: _balnk typo -> _blank
UI cleanup: ResourceUsageGauge, IconStatusResource, RangeSelector, Notifier WebHook render
Migrations update: AutoSnap (AddExtendedDataRemoveWebHooks), Dashboard (RemoveWidgetModuleType), System (AddAppTokens)
Translation: update source.json

Test plan

Save DRS settings on a cluster — verify no NullReferenceException and settings are persisted
Verify SendMessageDialog opens correctly from all call sites
Verify AppToken UI: create/edit/delete token, check permissions grid
Verify HelpMenu Provide Feedback link opens in new tab
Check EnumDropDown renders correctly with AllowFloatingLabel=false
Run EF migrations on clean DB (AutoSnap, Dashboard, System)

**Original Pull Request:** https://github.com/Corsinvest/cv4pve-admin/pull/236 **State:** closed **Merged:** No --- ## Summary - **Fix NullReferenceException** saving DRS settings: add `SetAsync<TModule,TSetting>` generic extension in `SettingsServiceExtensions` that resolves section/key via `GetContextModule`/`GetKeyModule`, avoiding dependency on `RenderSettingsInfo` (which is null for modules using NavBar Config instead of the settings dialog) - **Refactor SendMessageDialog**: moved out of `SendMessage/` subfolder, removed `SendMessageModel` class, added `SendMessageDialog.razor.cs` code-behind - **Move MessageSeverity** from `Session/` to `Models/` - **Move ISessionHubService** from `Session/` to `Services/`; delete `SessionHubService.cs` (dead code) - **AppToken support**: `AppTokenPermissionsGrid`, `WebApiCredentialSettings`, System migrations (AddAppTokens) - **EnumDropDown**: add `AllowFloatingLabel=false` default - **Fix HelpMenu** feedback link: _balnk typo -> _blank - **UI cleanup**: ResourceUsageGauge, IconStatusResource, RangeSelector, Notifier WebHook render - **Migrations update**: AutoSnap (AddExtendedDataRemoveWebHooks), Dashboard (RemoveWidgetModuleType), System (AddAppTokens) - **Translation**: update source.json ## Test plan - [ ] Save DRS settings on a cluster — verify no NullReferenceException and settings are persisted - [ ] Verify SendMessageDialog opens correctly from all call sites - [ ] Verify AppToken UI: create/edit/delete token, check permissions grid - [ ] Verify HelpMenu Provide Feedback link opens in new tab - [ ] Check EnumDropDown renders correctly with AllowFloatingLabel=false - [ ] Run EF migrations on clean DB (AutoSnap, Dashboard, System)