[PR #230] refactor: move SettingSection/SettingsAccordion from Module.System to Core #311

New issue

Closed

opened 2026-03-07 19:57:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 19:57:32 +03:00

Owner

Original Pull Request: https://github.com/Corsinvest/cv4pve-admin/pull/230

State: closed
Merged: Yes

Summary

Move SettingSection<T> and SettingsAccordion<T> from Module.System.Components to Core.Components.Settings, making them generic and reusable across all modules
Remove non-generic versions from Module.System
Update Module.System to use Core.Components.Settings types via SettingsHelper

Test plan

System module settings page renders correctly (SMTP configuration accordion)
No compilation errors from removed/renamed types

**Original Pull Request:** https://github.com/Corsinvest/cv4pve-admin/pull/230 **State:** closed **Merged:** Yes --- ## Summary - Move `SettingSection<T>` and `SettingsAccordion<T>` from `Module.System.Components` to `Core.Components.Settings`, making them generic and reusable across all modules - Remove non-generic versions from `Module.System` - Update `Module.System` to use `Core.Components.Settings` types via `SettingsHelper` ## Test plan - [ ] System module settings page renders correctly (SMTP configuration accordion) - [ ] No compilation errors from removed/renamed types