[PR #224] refactor: enhance search system with URL navigation and Data payload #306

Closed
opened 2026-03-07 19:57:31 +03:00 by kerem · 0 comments
Owner

Original Pull Request: https://github.com/Corsinvest/cv4pve-admin/pull/224

State: closed
Merged: Yes


Summary

  • Rename ExecuteOnExecute in search commands for naming consistency
  • Add Data property to SearchResultItem to carry associated objects (VM, Node)
  • Update CommandPalette to navigate directly to VM/Node detail URLs via UrlHelper
  • Refactor PveSearchProvider for improved code formatting

Test plan

  • Verify Command Palette (Ctrl+K) still opens and searches correctly
  • Verify clicking a VM result navigates to the VM detail page
  • Verify clicking a Node result navigates to the Node detail page
**Original Pull Request:** https://github.com/Corsinvest/cv4pve-admin/pull/224 **State:** closed **Merged:** Yes --- ## Summary - Rename `Execute` → `OnExecute` in search commands for naming consistency - Add `Data` property to `SearchResultItem` to carry associated objects (VM, Node) - Update `CommandPalette` to navigate directly to VM/Node detail URLs via `UrlHelper` - Refactor `PveSearchProvider` for improved code formatting ## Test plan - [ ] Verify Command Palette (Ctrl+K) still opens and searches correctly - [ ] Verify clicking a VM result navigates to the VM detail page - [ ] Verify clicking a Node result navigates to the Node detail page
kerem 2026-03-07 19:57:31 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cv4pve-admin#306
No description provided.