[PR #143] fix: fix installer interactive prompts and improve tag UX #277

New issue

Closed

opened 2026-03-07 19:57:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 19:57:10 +03:00

Owner

Original Pull Request: https://github.com/Corsinvest/cv4pve-admin/pull/143

State: closed
Merged: Yes

Summary

install.sh: fix read commands with </dev/tty so interactive prompts work when script is piped via curl | bash (root cause of #142)
install.sh + install.ps1: show available Docker Hub tags (based on edition CE/EE) before asking for version, with link to full tag list
install.sh, adminctl, .env: convert CRLF → LF (files were broken on Linux/macOS)
.gitattributes: enforce LF for shell scripts and .env, CRLF for .ps1
src/docker/README.md: correct tag format examples (2.0.0-rc1 instead of rc2)
src/docker/.env: improve tag comment with link to Docker Hub tags
docs/getting-started.md: update tag format examples

Fixes #142

Test plan

Run curl -fsSL .../install.sh | bash on Linux/macOS — verify interactive prompts appear correctly
Run irm .../install.ps1 | iex on Windows — verify tags are fetched and shown
Verify CE shows corsinvest/cv4pve-admin tags, EE shows corsinvest/cv4pve-admin-ee tags

**Original Pull Request:** https://github.com/Corsinvest/cv4pve-admin/pull/143 **State:** closed **Merged:** Yes --- ## Summary - **`install.sh`**: fix `read` commands with `</dev/tty` so interactive prompts work when script is piped via `curl | bash` (root cause of #142) - **`install.sh` + `install.ps1`**: show available Docker Hub tags (based on edition CE/EE) before asking for version, with link to full tag list - **`install.sh`, `adminctl`, `.env`**: convert CRLF → LF (files were broken on Linux/macOS) - **`.gitattributes`**: enforce LF for shell scripts and `.env`, CRLF for `.ps1` - **`src/docker/README.md`**: correct tag format examples (`2.0.0-rc1` instead of `rc2`) - **`src/docker/.env`**: improve tag comment with link to Docker Hub tags - **`docs/getting-started.md`**: update tag format examples Fixes #142 ## Test plan - [ ] Run `curl -fsSL .../install.sh | bash` on Linux/macOS — verify interactive prompts appear correctly - [ ] Run `irm .../install.ps1 | iex` on Windows — verify tags are fetched and shown - [ ] Verify CE shows `corsinvest/cv4pve-admin` tags, EE shows `corsinvest/cv4pve-admin-ee` tags