starred/cv4pve-admin
1
0
Fork 0
mirror of https://github.com/Corsinvest/cv4pve-admin.git synced 2026-04-25 12:55:57 +03:00
Code Issues 4 Projects Releases 10 Packages Wiki Activity

[PR #193] chore: unify Job/ActionHelper scan signature across analytics modules #183

New issue
Closed
opened 2026-02-26 17:37:39 +03:00 by kerem · 0 comments
kerem commented 2026-02-26 17:37:39 +03:00
Owner
Copy link

Original Pull Request: https://github.com/Corsinvest/cv4pve-admin/pull/193

State: closed
Merged: Yes

Summary

  • Merge ScanAsync/ScanFromResultAsync into a single ScanAsync method in BackupAnalytics, Diagnostic, ReplicationAnalytics, and Updater modules
  • Remove redundant automatic boolean parameter from ActionHelper.ScanAsync — all callers now use the same code path
  • Minor null-conditional and code style cleanup in Bots, NodeProtect, System modules
  • Small fixes in Maintenance, SystemInfo, ReleaseCheckHostedService, CurrentUserService, IdentityRevalidatingAuthenticationStateProvider

Test plan

  • Verify manual scan still works from the UI in BackupAnalytics, Diagnostic, ReplicationAnalytics
  • Verify scheduled/automatic scan jobs still execute correctly
  • Verify Bots/Telegram render still works
**Original Pull Request:** https://github.com/Corsinvest/cv4pve-admin/pull/193 **State:** closed **Merged:** Yes --- ## Summary - Merge `ScanAsync`/`ScanFromResultAsync` into a single `ScanAsync` method in BackupAnalytics, Diagnostic, ReplicationAnalytics, and Updater modules - Remove redundant `automatic` boolean parameter from `ActionHelper.ScanAsync` — all callers now use the same code path - Minor null-conditional and code style cleanup in Bots, NodeProtect, System modules - Small fixes in Maintenance, SystemInfo, ReleaseCheckHostedService, CurrentUserService, IdentityRevalidatingAuthenticationStateProvider ## Test plan - [ ] Verify manual scan still works from the UI in BackupAnalytics, Diagnostic, ReplicationAnalytics - [ ] Verify scheduled/automatic scan jobs still execute correctly - [ ] Verify Bots/Telegram render still works
kerem 2026-02-26 17:37:39 +03:00
kerem changed title from [PR #193] [MERGED] chore: unify Job/ActionHelper scan signature across analytics modules to [PR #193] chore: unify Job/ActionHelper scan signature across analytics modules 2026-03-07 19:57:23 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
gh-pages
feat/vm-jolly-field
v2.0.0
v2.0.0-rc6
v2.0.0-rc5
v2.0.0-rc4
v2.0.0-rc3
v2.0.0-rc2
v2.0.0-rc1
v1.3.1
v1.3.0
v1.2.0
v1.1.3
v1.1.2
v1.1.1
v1.1.0
v1.0.2
v1.0.1
v1.0.0
v1.0.0-rc.3
v1.0.0-rc.2
v1.0.0-rc.1
v0.0.7-beta
v0.0.6-beta
v0.0.5-beta
v0.0.4-beta
v0.0.3-beta
v0.0.2-beta
v0.0.1-beta
Labels
Clear labels   
bug

   
bug

   
enhancement

   
feedback

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
bug
enhancement
feedback
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cv4pve-admin#183
No description provided.