[PR #143] [MERGED] fix: fix installer interactive prompts and improve tag UX #136

New issue

Closed

opened 2026-02-26 17:37:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 17:37:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Corsinvest/cv4pve-admin/pull/143
Author: @franklupo
Created: 2/16/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @franklupo

Base: main ← Head: fix/installer-issues

📝 Commits (1)

d8cc887 fix: fix installer interactive prompts and improve tag UX

📊 Changes

6 files changed (+66 additions, -15 deletions)

View changed files

➕ .gitattributes (+19 -0)
📝 docs/user/docs/getting-started.md (+1 -1)
📝 install.ps1 (+17 -0)
📝 install.sh (+18 -3)
📝 src/docker/.env (+2 -2)
📝 src/docker/README.md (+9 -9)

📄 Description

Summary

install.sh: fix read commands with </dev/tty so interactive prompts work when script is piped via curl | bash (root cause of #142)
install.sh + install.ps1: show available Docker Hub tags (based on edition CE/EE) before asking for version, with link to full tag list
install.sh, adminctl, .env: convert CRLF → LF (files were broken on Linux/macOS)
.gitattributes: enforce LF for shell scripts and .env, CRLF for .ps1
src/docker/README.md: correct tag format examples (2.0.0-rc1 instead of rc2)
src/docker/.env: improve tag comment with link to Docker Hub tags
docs/getting-started.md: update tag format examples

Fixes #142

Test plan

Run curl -fsSL .../install.sh | bash on Linux/macOS — verify interactive prompts appear correctly
Run irm .../install.ps1 | iex on Windows — verify tags are fetched and shown
Verify CE shows corsinvest/cv4pve-admin tags, EE shows corsinvest/cv4pve-admin-ee tags

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Corsinvest/cv4pve-admin/pull/143 **Author:** [@franklupo](https://github.com/franklupo) **Created:** 2/16/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@franklupo](https://github.com/franklupo) **Base:** `main` ← **Head:** `fix/installer-issues` --- ### 📝 Commits (1) - [`d8cc887`](https://github.com/Corsinvest/cv4pve-admin/commit/d8cc8872e181439c65647705a3df311caab5f467) fix: fix installer interactive prompts and improve tag UX ### 📊 Changes **6 files changed** (+66 additions, -15 deletions) <details> <summary>View changed files</summary> ➕ `.gitattributes` (+19 -0) 📝 `docs/user/docs/getting-started.md` (+1 -1) 📝 `install.ps1` (+17 -0) 📝 `install.sh` (+18 -3) 📝 `src/docker/.env` (+2 -2) 📝 `src/docker/README.md` (+9 -9) </details> ### 📄 Description ## Summary - **`install.sh`**: fix `read` commands with `</dev/tty` so interactive prompts work when script is piped via `curl | bash` (root cause of #142) - **`install.sh` + `install.ps1`**: show available Docker Hub tags (based on edition CE/EE) before asking for version, with link to full tag list - **`install.sh`, `adminctl`, `.env`**: convert CRLF → LF (files were broken on Linux/macOS) - **`.gitattributes`**: enforce LF for shell scripts and `.env`, CRLF for `.ps1` - **`src/docker/README.md`**: correct tag format examples (`2.0.0-rc1` instead of `rc2`) - **`src/docker/.env`**: improve tag comment with link to Docker Hub tags - **`docs/getting-started.md`**: update tag format examples Fixes #142 ## Test plan - [ ] Run `curl -fsSL .../install.sh | bash` on Linux/macOS — verify interactive prompts appear correctly - [ ] Run `irm .../install.ps1 | iex` on Windows — verify tags are fetched and shown - [ ] Verify CE shows `corsinvest/cv4pve-admin` tags, EE shows `corsinvest/cv4pve-admin-ee` tags --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>