[GH-ISSUE #35] Possible bug #24

Open
opened 2026-03-02 03:21:20 +03:00 by kerem · 1 comment
Owner

Originally created by @bozhinov on GitHub (Jan 26, 2021).
Original GitHub issue: https://github.com/clonos/control-pane/issues/35

Originally assigned to: @olevole on GitHub.

github.com/clonos/control-pane@aef78b7125/php/clonos.php (L2062)

$add_cmd=($in_helper)?' default_jailname='.$this->url_hash:'';
$add_cmd1=' default_jailname='.$type;
$res=$this->cbsd_cmd("freejname".$add_cmd.$add_cmd1);

after refactoring this translates to:
if ($in_helper) {
$res = CBSD::run('freejname default_jailname=%s default_jailname=%s', array($this->url_hash, $type));
} else {
$res = CBSD::run('freejname default_jailname=%s', array($type));
}

The double default_jailname looks weird
it this correct ?

Originally created by @bozhinov on GitHub (Jan 26, 2021). Original GitHub issue: https://github.com/clonos/control-pane/issues/35 Originally assigned to: @olevole on GitHub. https://github.com/clonos/control-pane/blob/aef78b712561759469ab09d713cff967b6db212d/php/clonos.php#L2062 $add_cmd=($in_helper)?' default_jailname='.$this->url_hash:''; $add_cmd1=' default_jailname='.$type; $res=$this->cbsd_cmd("freejname".$add_cmd.$add_cmd1); after refactoring this translates to: if ($in_helper) { $res = CBSD::run('freejname default_jailname=%s default_jailname=%s', array($this->url_hash, $type)); } else { $res = CBSD::run('freejname default_jailname=%s', array($type)); } The double default_jailname looks weird it this correct ?
Author
Owner

@olevole commented on GitHub (Feb 21, 2021):

@moveee cbsd assumes one argument for default_jname. Can you check and remove the dubbing?

<!-- gh-comment-id:782855200 --> @olevole commented on GitHub (Feb 21, 2021): @moveee cbsd assumes one argument for `default_jname`. Can you check and remove the dubbing?
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/control-pane#24
No description provided.