[GH-ISSUE #149] Invalid GUIDs for two scripts #5

New issue

Open

opened 2026-03-02 02:10:02 +03:00 by kerem · 2 comments

kerem commented

2026-03-02 02:10:02 +03:00

Owner

Originally created by @NiceGuyIT on GitHub (May 15, 2023).
Original GitHub issue: https://github.com/amidaware/community-scripts/issues/149

While working with the community scripts, I noticed two of them have invalid GUIDs. These are 1 character longer than regular GUIDs. Since changing the GUID will cause the script to disappear for anyone using it, maybe add the scripts with valid GUIDs and rename the existing scripts with a warning.

  {
    "guid": "5a60c13b-1882-4a92-bdfb-6dd1f6a11dd14",
    "filename": "Win_Windows_Update_RevertToDefault.ps1",
    "submittedBy": "https://github.com/silversword411",
    "name": "Windows Update - Re-enable Microsoft managed Windows Update",
    "description": "TRMM agent will set registry key to disable Windows Auto Updates. This will re-enable Windows standard update settings",
    "shell": "powershell",
    "category": "TRMM (Win):Updates",
    "supported_platforms": [
      "windows"
    ],
    "default_timeout": "90"
  }

  {
    "guid": "6e27d5341-88fa-4c2f-9c91-c3aeb1740e85",
    "filename": "Win_User_EnableDisable.ps1",
    "submittedBy": "https://github.com/silversword411",
    "name": "User - Enable or disable a user",
    "description": "Used to enable or disable local user",
    "syntax": "-Name <string>\n-Enabled { yes | no }",
    "shell": "powershell",
    "supported_platforms": [
      "windows"
    ],
    "category": "TRMM (Win):User Management"
  }

As a side note, the kernel can provide a random GUID.

$ cat /proc/sys/kernel/random/uuid

Originally created by @NiceGuyIT on GitHub (May 15, 2023). Original GitHub issue: https://github.com/amidaware/community-scripts/issues/149 While working with the community scripts, I noticed two of them have invalid GUIDs. These are 1 character longer than regular GUIDs. Since changing the GUID will cause the script to disappear for anyone using it, maybe add the scripts with valid GUIDs and rename the existing scripts with a warning. ```json { "guid": "5a60c13b-1882-4a92-bdfb-6dd1f6a11dd14", "filename": "Win_Windows_Update_RevertToDefault.ps1", "submittedBy": "https://github.com/silversword411", "name": "Windows Update - Re-enable Microsoft managed Windows Update", "description": "TRMM agent will set registry key to disable Windows Auto Updates. This will re-enable Windows standard update settings", "shell": "powershell", "category": "TRMM (Win):Updates", "supported_platforms": [ "windows" ], "default_timeout": "90" } ``` ```json { "guid": "6e27d5341-88fa-4c2f-9c91-c3aeb1740e85", "filename": "Win_User_EnableDisable.ps1", "submittedBy": "https://github.com/silversword411", "name": "User - Enable or disable a user", "description": "Used to enable or disable local user", "syntax": "-Name <string>\n-Enabled { yes | no }", "shell": "powershell", "supported_platforms": [ "windows" ], "category": "TRMM (Win):User Management" } ``` As a side note, the kernel can provide a random GUID. ```bash $ cat /proc/sys/kernel/random/uuid ```

kerem commented

2026-03-02 02:10:03 +03:00

Author

Owner

@silversword411 commented on GitHub (Sep 19, 2023):

@NiceGuyIT Don't know how I missed this before...but aren't there multiple GUID formats/standards?

As long as they're unique, shouldn't matter if they're not an extra character. Maybe when we eventually fix the deleted/renamed script problems we have now we can make 'em all the same

@silversword411 commented on GitHub (Sep 19, 2023): @NiceGuyIT Don't know how I missed this before...but aren't there multiple GUID formats/standards? As long as they're unique, shouldn't matter if they're not an extra character. Maybe when we eventually fix the deleted/renamed script problems we have now we can make 'em all the same

kerem commented

2026-03-02 02:10:03 +03:00

Author

Owner

@NiceGuyIT commented on GitHub (Sep 19, 2023):

While there are multiple GUID formats, these are one character extra and do not adhere to the format.

This is an issue for the community_scripts.schema.json to determine the type for the "GUID" field which can be used to validate if community_scripts.json is valid. The validation can be used to setup a CI/GitHub Actions to ensure only valid entries are submitted. If the GUID for these scripts are not corrected, the GUID is treated like a text field and validation is not possible.

Note: The fact these are not valid GUIDs implies TacticalRMM does not treat these fields like GUIDs. I.e. The Python script to load the JSON, The PostgreSQL field type, the API, etc. all treat this like a text field.

community_scripts.schema.json

      "guid": {
        "description": "Unique ID for the script.",
        "type": "uuid"
      },

@NiceGuyIT commented on GitHub (Sep 19, 2023): While there are multiple GUID formats, these are one character extra and do not adhere to the format. This is an issue for the `community_scripts.schema.json` to determine the type for the "GUID" field which can be used to validate if `community_scripts.json` is valid. The validation can be used to setup a CI/GitHub Actions to ensure only valid entries are submitted. If the GUID for these scripts are not corrected, the GUID is treated like a text field and validation is not possible. Note: The fact these are not valid GUIDs implies TacticalRMM does not treat these fields like GUIDs. I.e. The Python script to load the JSON, The PostgreSQL field type, the API, etc. all treat this like a text field. [community_scripts.schema.json](https://github.com/amidaware/community-scripts/blob/700ef9b8435e4d54641dc748aab3b5b3d692b2de/community_scripts.schema.json#L54C1-L57C9) ```json "guid": { "description": "Unique ID for the script.", "type": "uuid" }, ```