mirror of
https://github.com/amidaware/community-scripts.git
synced 2026-04-26 06:25:54 +03:00
[GH-ISSUE #55] Modify tests to check for duplicate entries #311
Labels
No labels
enhancement
good first issue
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/community-scripts#311
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @silversword411 on GitHub (Jun 23, 2022).
Original GitHub issue: https://github.com/amidaware/community-scripts/issues/55
See:
github.com/amidaware/community-scripts@eaf62b855c/community_scripts.json (L578)and
github.com/amidaware/community-scripts@eaf62b855c/community_scripts.json (L582)Should probably make sure all fields aren't duplicated
@silversword411 commented on GitHub (Jun 23, 2022):
@wh1te909 ...did we try doing this already and couldn't get it to work?
@wh1te909 commented on GitHub (Jun 23, 2022):
python does not allow dicts to have duplicate keys so when it's imported, the duplicate is removed automatically, but this can lead to unexpected behavior because we won't know which line was removed. I have just addded a check to catch duplicates
@wh1te909 commented on GitHub (Jun 23, 2022):
https://github.com/amidaware/community-scripts/runs/7028877647?check_suite_focus=true shows it catching it